From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Prasanna S Panchamukhi <prasanna@in.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp>,
Rusty Lynch <rusty.lynch@intel.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
maneesh@linux.vnet.ibm.com, srinivasa@in.ibm.com,
Jim Keniston <jkenisto@us.ibm.com>,
Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
Subject: Re: FInal kprobes rollup patches
Date: Mon, 17 Dec 2007 19:42:13 +0530 [thread overview]
Message-ID: <20071217141213.GA20093@linux.vnet.ibm.com> (raw)
In-Reply-To: <20071215131204.GE9720@elte.hu>
Hi Ingo, Harvey
In file include/asm-x86/kprobes_32.h
typedef u8 kprobe_opcode_t;
hence sizeof(kprobe_opcode_t) turns out to be 1.
Hence
memcpy(p->ainsn.insn, p->addr, MAX_INSN_SIZE * sizeof(kprobe_opcode_t));
is correct.
--
Regards
Srikar
>
> * Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > If you compare this memcpy from arch_prepare_kprobe in 32/64 bit I'm
> > almost sure the X86_32 version should be
> >
> > ... + sizeof(kprobe_opcode_t)
> >
> > not
> >
> > ... * sizeof(kprobe_opcode_t)
>
> good point. I've Cc:-ed the top authors of kprobes.c. Could anyone
> confirm (or deny) that Harvey found a real kprobes bug here?
>
> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2007-12-17 14:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-15 8:45 FInal kprobes rollup patches Harvey Harrison
2007-12-15 8:50 ` Ingo Molnar
2007-12-15 9:04 ` Harvey Harrison
2007-12-15 13:12 ` Ingo Molnar
2007-12-17 14:12 ` Srikar Dronamraju [this message]
2007-12-17 14:13 ` Masami Hiramatsu
2007-12-17 14:30 ` Final " Ingo Molnar
2007-12-17 15:29 ` Masami Hiramatsu
2007-12-17 16:06 ` Ingo Molnar
2007-12-17 16:19 ` Masami Hiramatsu
2007-12-17 20:17 ` Harvey Harrison
2007-12-17 14:22 ` FInal " Srikar Dronamraju
2007-12-17 19:20 ` Harvey Harrison
2007-12-17 21:28 ` Masami Hiramatsu
2007-12-17 21:36 ` Harvey Harrison
2007-12-17 21:52 ` Masami Hiramatsu
2007-12-17 22:00 ` Harvey Harrison
2007-12-17 23:14 ` Masami Hiramatsu
2007-12-17 23:27 ` Harvey Harrison
2007-12-17 23:56 ` Masami Hiramatsu
2007-12-18 0:27 ` Masami Hiramatsu
2007-12-18 2:15 ` Harvey Harrison
2007-12-18 3:10 ` [PATCH] x86: kprobes use stack_addr() macro Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217141213.GA20093@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=harvey.harrison@gmail.com \
--cc=hiramatu@sdl.hitachi.co.jp \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@linux.vnet.ibm.com \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@elte.hu \
--cc=prasanna@in.ibm.com \
--cc=rusty.lynch@intel.com \
--cc=srinivasa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox