Re: [PATCH] AMD Thermal Interrupt Support

Russell Leidich
2008-01-09T02:28:44Z

On Jan 8, 2008 3:52 PM, Andi Kleen <andi@firstfloor.org> wrote:
> > ENTRY(thermal_interrupt)
> > - apicinterrupt THERMAL_APIC_VECTOR,smp_thermal_interrupt
> > + apicinterrupt THERMAL_APIC_VECTOR,smp_thermal_interrupt(%rip)
>
> Are you sure a * is not needed? I would have thought it would jump
> to the variable instead of through it. But if it works it's ok for me.

I will test to make sure it works. I don't think stars mean anything
in AT&T-style X86-64.

>
> The rest of the patch looks ok to to me.

Thank you! I will give it a final test and submit the official patch this week.

>
> -Andi
>
>

--
Russell Leidich