Re: [PATCH] AMD Thermal Interrupt Support

Andi Kleen
2008-01-09T02:34:58Z

On Tue, Jan 08, 2008 at 06:28:18PM -0800, Russell Leidich wrote:
> On Jan 8, 2008 3:52 PM, Andi Kleen <andi@firstfloor.org> wrote:
> > > ENTRY(thermal_interrupt)
> > > - apicinterrupt THERMAL_APIC_VECTOR,smp_thermal_interrupt
> > > + apicinterrupt THERMAL_APIC_VECTOR,smp_thermal_interrupt(%rip)
> >
> > Are you sure a * is not needed? I would have thought it would jump
> > to the variable instead of through it. But if it works it's ok for me.
>
> I will test to make sure it works. I don't think stars mean anything
> in AT&T-style X86-64.

% cat t.s
call foo
call *foo
% as -o t.o t.s
% objdump -S t.o

t.o: file format elf64-x86-64

Disassembly of section .text:

0000000000000000 <.text>:
0: e8 00 00 00 00 callq 0x5
5: ff 14 25 00 00 00 00 callq *0x0

-Andi