public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linux-pci@atrey.karlin.mff.cuni.cz
Cc: Alan Cox <alan@redhat.com>, Greg Kroah-Hartman <greg@kroah.com>,
	<jgarzik@pobox.com>, Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	<wingel@nano-system.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	<james.smart@emulex.com>, <linux-driver@qlogic.com>,
	<linux-kernel@vger.kernel.org>
Subject: [RFC/PATCH 3/4] pci: Remove pci_enable_device_bars()
Date: Tue, 18 Dec 2007 10:01:14 +1100	[thread overview]
Message-ID: <20071217230126.B2D71DDE36@ozlabs.org> (raw)
In-Reply-To: <1197932473.576079.142524077033.qpush@grosgo>

Now that all in-tree users are gone, this removes pci_enable_device_bars()
completely.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

 drivers/pci/pci.c   |   32 +++++++-------------------------
 include/linux/pci.h |    1 -
 2 files changed, 7 insertions(+), 26 deletions(-)

--- linux-work.orig/drivers/pci/pci.c	2007-12-18 09:38:25.000000000 +1100
+++ linux-work/drivers/pci/pci.c	2007-12-18 09:39:04.000000000 +1100
@@ -714,29 +714,6 @@ int pci_reenable_device(struct pci_dev *
 }
 
 /**
- * pci_enable_device_bars - Initialize some of a device for use
- * @dev: PCI device to be initialized
- * @bars: bitmask of BAR's that must be configured
- *
- *  Initialize device before it's used by a driver. Ask low-level code
- *  to enable selected I/O and memory resources. Wake up the device if it
- *  was suspended. Beware, this function can fail.
- */
-int
-pci_enable_device_bars(struct pci_dev *dev, int bars)
-{
-	int err;
-
-	if (atomic_add_return(1, &dev->enable_cnt) > 1)
-		return 0;		/* already enabled */
-
-	err = do_pci_enable_device(dev, bars);
-	if (err < 0)
-		atomic_dec(&dev->enable_cnt);
-	return err;
-}
-
-/**
  * pci_enable_device_io - Initialize a device for use with IO space
  * @dev: PCI device to be initialized
  *
@@ -801,7 +778,13 @@ int pci_enable_device_mem(struct pci_dev
  */
 int pci_enable_device(struct pci_dev *dev)
 {
-	return pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1);
+	if (atomic_add_return(1, &dev->enable_cnt) > 1)
+		return 0;		/* already enabled */
+
+	err = do_pci_enable_device(dev, (1 << PCI_NUM_RESOURCES) - 1);
+	if (err < 0)
+		atomic_dec(&dev->enable_cnt);
+	return err;
 }
 
 /*
@@ -1672,7 +1655,6 @@ device_initcall(pci_init);
 
 EXPORT_SYMBOL_GPL(pci_restore_bars);
 EXPORT_SYMBOL(pci_reenable_device);
-EXPORT_SYMBOL(pci_enable_device_bars);
 EXPORT_SYMBOL(pci_enable_device_io);
 EXPORT_SYMBOL(pci_enable_device_mem);
 EXPORT_SYMBOL(pci_enable_device);
Index: linux-work/include/linux/pci.h
===================================================================
--- linux-work.orig/include/linux/pci.h	2007-12-18 09:39:20.000000000 +1100
+++ linux-work/include/linux/pci.h	2007-12-18 09:39:22.000000000 +1100
@@ -547,7 +547,6 @@ static inline int pci_write_config_dword
 }
 
 int __must_check pci_enable_device(struct pci_dev *dev);
-int __must_check pci_enable_device_bars(struct pci_dev *dev, int mask);
 int __must_check pci_enable_device_io(struct pci_dev *dev);
 int __must_check pci_enable_device_mem(struct pci_dev *dev);
 int __must_check pci_reenable_device(struct pci_dev *);

  parent reply	other threads:[~2007-12-17 23:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-17 23:01 [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces Benjamin Herrenschmidt
2007-12-17 23:01 ` [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars() Benjamin Herrenschmidt
2007-12-18  0:07   ` Alan Cox
2007-12-18  0:26     ` Benjamin Herrenschmidt
2007-12-24  7:13   ` Grant Grundler
2007-12-17 23:01 ` Benjamin Herrenschmidt [this message]
2007-12-24  7:08   ` [RFC/PATCH 3/4] pci: Remove pci_enable_device_bars() Grant Grundler
2007-12-25 21:16     ` Benjamin Herrenschmidt
2007-12-17 23:01 ` [RFC/PATCH 4/4] [POWERPC] pci: Disable IO/Mem on a device when resources can't be allocated Benjamin Herrenschmidt
2007-12-18  9:56   ` Ivan Kokshaysky
2007-12-18 11:36     ` Benjamin Herrenschmidt
2007-12-24  7:23   ` Grant Grundler
2007-12-25 21:20     ` Benjamin Herrenschmidt
2007-12-25 21:26       ` Benjamin Herrenschmidt
2007-12-27 21:03         ` Grant Grundler
2007-12-17 23:49 ` [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces Johannes Weiner
2007-12-17 23:55   ` Benjamin Herrenschmidt
2007-12-18  0:02   ` Benjamin Herrenschmidt
2007-12-18  9:37     ` Ivan Kokshaysky
2007-12-18  9:43       ` Benjamin Herrenschmidt
2007-12-19  5:10       ` [RFC/PATCH]] x86: pci: Disable IO/Mem on a device when resources can't be allocated Benjamin Herrenschmidt
2007-12-19 13:43         ` Ivan Kokshaysky
2007-12-19 20:29           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071217230126.B2D71DDE36@ozlabs.org \
    --to=benh@kernel.crashing.org \
    --cc=alan@redhat.com \
    --cc=bzolnier@gmail.com \
    --cc=greg@kroah.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=james.smart@emulex.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-driver@qlogic.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=wingel@nano-system.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox