public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: akepner@sgi.com
To: Andrew Morton <akpm@linux-foundation.org>,
	grundler@parisc-linux.org, jbarnes@virtuousgeek.org, jes@sgi.com,
	randy.dunlap@oracle.com, rdreier@cisco.com,
	James.Bottomley@steeleye.com, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org
Subject: [RFC] dma: passing "attributes" to dma_map_* routines
Date: Mon, 17 Dec 2007 16:17:58 -0800	[thread overview]
Message-ID: <20071218001758.GO21916@sgi.com> (raw)


Waaay back in October I sent some patches for passing additional 
attributes to the dma_map_* routines:

http://marc.info/?l=linux-kernel&m=119137949604365&w=2

This is somthing needed for ia64 Altix NUMA machines (as described 
in that thread).

Several folks objected to the approach I used - it was a bit of a 
hack - and so these patches were dropped. 

This time I'd like to get something resembling concensus before 
spending much time on this. 

Can you please comment on the options listed here, or suggest 
alternatives?

We could:

1) add an additional parameter to the dma_map_* routines, somthing 
   like:

     dma_map_single(struct device *dev, void *cpu_addr, size_t size,
                    enum dma_data_direction direction, u32 flags)
     ....

2) change the "direction" argument to be a field of bits:

     dma_map_single(struct device *dev, void *cpu_addr, size_t size,
                    u32 flags)
     ....

     where flags encodes the direction and optionally other attributes.

3) add new functions to the dma interface, e.g.:

     dma_map_single_attrs(struct device *dev, void *cpu_addr, size_t size,
                          enum dma_data_direction direction, u32 attrs)
     .....

1) and 2) are going to require many minor changes, and 3) is going 
to pollute the dma interface a bit. 

Other ideas?

-- 
Arthur


             reply	other threads:[~2007-12-18  0:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-18  0:17 akepner [this message]
2007-12-18 16:50 ` [RFC] dma: passing "attributes" to dma_map_* routines Stefan Richter
2007-12-18 19:04   ` Roland Dreier
2007-12-18 20:07   ` akepner
2007-12-18 20:59     ` Stefan Richter
2007-12-18 21:09       ` Roland Dreier
2007-12-20 18:51       ` akepner
2007-12-20 19:06       ` akepner
2007-12-20 20:56     ` Benjamin Herrenschmidt
2007-12-21 18:00       ` akepner
2007-12-21 20:24         ` Stefan Richter
2007-12-21 21:31         ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071218001758.GO21916@sgi.com \
    --to=akepner@sgi.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=grundler@parisc-linux.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox