From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Johannes Weiner <hannes@saeurebad.de>,
linux-pci@atrey.karlin.mff.cuni.cz, Alan Cox <alan@redhat.com>,
Greg Kroah-Hartman <greg@kroah.com>,
jgarzik@pobox.com, wingel@nano-system.com,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
james.smart@emulex.com, linux-driver@qlogic.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces
Date: Tue, 18 Dec 2007 12:37:15 +0300 [thread overview]
Message-ID: <20071218123715.A7874@jurassic.park.msu.ru> (raw)
In-Reply-To: <1197936157.13400.9.camel@pasglop>; from benh@kernel.crashing.org on Tue, Dec 18, 2007 at 11:02:37AM +1100
On Tue, Dec 18, 2007 at 11:02:37AM +1100, Benjamin Herrenschmidt wrote:
> +EXPORT_SYMBOL(pci_enable_device_io);
> +EXPORT_SYMBOL(pci_enable_device_mem);
> EXPORT_SYMBOL(pci_enable_device);
Wouldn't it be better to export only the pci_enable_device_flags()
and make these three just "static inline" wrappers in pci.h?
> EXPORT_SYMBOL(pcim_enable_device);
Looks like many SATA drivers would benefit from pcim_* equivalents
of pci_enable_device_{io,mem}, as they could happily work with just
a single MMIO BAR... Alan?
Ivan.
next prev parent reply other threads:[~2007-12-18 9:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 23:01 [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces Benjamin Herrenschmidt
2007-12-17 23:01 ` [RFC/PATCH 2/4] pci: Remove users of pci_enable_device_bars() Benjamin Herrenschmidt
2007-12-18 0:07 ` Alan Cox
2007-12-18 0:26 ` Benjamin Herrenschmidt
2007-12-24 7:13 ` Grant Grundler
2007-12-17 23:01 ` [RFC/PATCH 3/4] pci: Remove pci_enable_device_bars() Benjamin Herrenschmidt
2007-12-24 7:08 ` Grant Grundler
2007-12-25 21:16 ` Benjamin Herrenschmidt
2007-12-17 23:01 ` [RFC/PATCH 4/4] [POWERPC] pci: Disable IO/Mem on a device when resources can't be allocated Benjamin Herrenschmidt
2007-12-18 9:56 ` Ivan Kokshaysky
2007-12-18 11:36 ` Benjamin Herrenschmidt
2007-12-24 7:23 ` Grant Grundler
2007-12-25 21:20 ` Benjamin Herrenschmidt
2007-12-25 21:26 ` Benjamin Herrenschmidt
2007-12-27 21:03 ` Grant Grundler
2007-12-17 23:49 ` [RFC/PATCH 1/4] pci: Add pci_enable_device_{io,mem} intefaces Johannes Weiner
2007-12-17 23:55 ` Benjamin Herrenschmidt
2007-12-18 0:02 ` Benjamin Herrenschmidt
2007-12-18 9:37 ` Ivan Kokshaysky [this message]
2007-12-18 9:43 ` Benjamin Herrenschmidt
2007-12-19 5:10 ` [RFC/PATCH]] x86: pci: Disable IO/Mem on a device when resources can't be allocated Benjamin Herrenschmidt
2007-12-19 13:43 ` Ivan Kokshaysky
2007-12-19 20:29 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218123715.A7874@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=alan@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=greg@kroah.com \
--cc=hannes@saeurebad.de \
--cc=james.smart@emulex.com \
--cc=jgarzik@pobox.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=wingel@nano-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox