Re: [PATCH] apm_event{,info}_t are userspace types.

Andrew Morton
2007-12-12T10:47:46Z

On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:

> These types define the size of data read from /dev/apm_bios. They
> should not be hidden behind #ifdef __KERNEL__.

Missing info: what are the consequences of this fix? What id broken when
it it not applied?

> ---
> include/linux/apm_bios.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

Please include Signed-off-by:, as per Documentation/SubmittingPatches,
thanks.

> diff --git a/include/linux/apm_bios.h b/include/linux/apm_bios.h
> index 9754baa..01a6244 100644
> --- a/include/linux/apm_bios.h
> +++ b/include/linux/apm_bios.h
> @@ -18,6 +18,9 @@
>
> #include <linux/types.h>
>
> +typedef unsigned short apm_event_t;
> +typedef unsigned short apm_eventinfo_t;
> +
> struct apm_bios_info {
> __u16 version;
> __u16 cseg;
> @@ -32,9 +35,6 @@ struct apm_bios_info {
>
> #ifdef __KERNEL__
>
> -typedef unsigned short apm_event_t;
> -typedef unsigned short apm_eventinfo_t;
> -
> #define APM_CS (GDT_ENTRY_APMBIOS_BASE * 8)
> #define APM_CS_16 (APM_CS + 8)
> #define APM_DS (APM_CS_16 + 8)