Re: [PATCH] apm_event{,info}_t are userspace types.

Adam Jackson
2007-12-19T18:36:17Z

On Wed, 2007-12-12 at 02:47 -0800, Andrew Morton wrote:
> On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:
> > These types define the size of data read from /dev/apm_bios. They
> > should not be hidden behind #ifdef __KERNEL__.
>
> Missing info: what are the consequences of this fix? What id broken when
> it it not applied?

The X server won't build. Neither will apmd, but it's harder for me to
get worked up about that.

> > ---
> > include/linux/apm_bios.h | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
>
> Please include Signed-off-by:, as per Documentation/SubmittingPatches,
> thanks.

Blah. Right, will remember git-format-patch -s next time. In any
event:

Signed-off-by: Adam Jackson <ajax@redhat.com>

- ajax