From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Ritz <daniel.ritz-ml@swissonline.ch>
Cc: dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org,
daniel.ritz@gmx.ch, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] usbtouchscreen: fix buffer overflow, make more egalax work
Date: Tue, 18 Dec 2007 16:12:54 -0800 [thread overview]
Message-ID: <20071218161254.ca6ee09a.akpm@linux-foundation.org> (raw)
In-Reply-To: <200712112105.11184.daniel.ritz-ml@swissonline.ch>
On Tue, 11 Dec 2007 21:05:10 +0100
Daniel Ritz <daniel.ritz-ml@swissonline.ch> wrote:
> [PATCH] usbtouchscreen: fix buffer overflow, make more egalax work
>
> fixes a buffer overflow in mutli-packet handling code. the overflow can only
> happen with eGalax devices and is even there very unlikely (only non-report
> packet are affected any only when truncated after the first byte).
>
> it also changes the mutli-packet handling code not to drop unknown packets,
> but rather just drop one byte. this allows synchronizing on report packets
> in the data stream. it's required for some egalax devices to work at all.
>
> also removes the pointless 'flags' member of the device struct and sets the
> version number to 0.6. and some minor cleanups.
>
Sentences start with a capital letter, please.
The term "buffer overflow" tends to get people's juices flowing, yet this
patch has been languishing for a week.
I'll queue it up as for-2.6.24-unless-someone-tells-me-otherwise, thanks.
(After having capitalised the sentences, grr.)
prev parent reply other threads:[~2007-12-19 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 20:05 [PATCH] usbtouchscreen: fix buffer overflow, make more egalax work Daniel Ritz
2007-12-19 0:12 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218161254.ca6ee09a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel.ritz-ml@swissonline.ch \
--cc=daniel.ritz@gmx.ch \
--cc=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox