From: Matt Mackall <mpm@selenic.com>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] procfs : Move some extern declaration from fs/proc/proc_misc.c to include/linux/seq_file.h
Date: Tue, 18 Dec 2007 16:22:59 -0600 [thread overview]
Message-ID: <20071218222259.GX17536@waste.org> (raw)
In-Reply-To: <47683ADE.3080107@cosmosbay.com>
On Tue, Dec 18, 2007 at 10:25:50PM +0100, Eric Dumazet wrote:
> Some 'extern struct seq_operations' are wrongly defined in
> fs/proc/proc_misc.c (they miss a const qualifier)
>
> In order to fix this correctly, move the "extern ... " declaration from .c
> file to an appropriate include file, as advised by checkpatch.pl
>
> Note : "extern struct seq_operations cpuinfo_op;" will be taken into account
> in a separate patch, since its const status is arch dependant.
seq_file.h doesn't seem the best place for these, as it's otherwise
unpolluted with anything but seq_file internals.
Most of these things perhaps ought to be pushed out to their relevant
subsystems and then no .h file declaration will be needed.
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-12-18 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 21:25 [PATCH] procfs : Move some extern declaration from fs/proc/proc_misc.c to include/linux/seq_file.h Eric Dumazet
2007-12-18 22:22 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218222259.GX17536@waste.org \
--to=mpm@selenic.com \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox