public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] x86: fix show cpuinfo cpu number always zero
@ 2007-12-18 23:37 travis
  2007-12-18 23:37 ` [PATCH 1/1] " travis
  0 siblings, 1 reply; 2+ messages in thread
From: travis @ 2007-12-18 23:37 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Andi Kleen, Christoph Lameter, Jack Steiner, Suresh B Siddha,
	linux-mm, linux-kernel


It appears that this patch is missing from the latest 2.6.24 git
kernel as well as the 2.6.24-rc5-mm1 patch?

> Mike, This issue still seems to be present in linus git tree. Perhaps
> the fix in -mm not pushed to mainline yet.
> 
> Can you please raise the flag with Andrew, so that he can push it before
> 2.6.24 gets out
> 

-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH 1/1] x86: fix show cpuinfo cpu number always zero
  2007-12-18 23:37 [PATCH 0/1] x86: fix show cpuinfo cpu number always zero travis
@ 2007-12-18 23:37 ` travis
  0 siblings, 0 replies; 2+ messages in thread
From: travis @ 2007-12-18 23:37 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Andi Kleen, Christoph Lameter, Jack Steiner, Suresh B Siddha,
	linux-mm, linux-kernel

[-- Attachment #1: cpuinfo_x86-fix --]
[-- Type: text/plain, Size: 660 bytes --]

This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.

The error shows up in 'cat /proc/cpuinfo' will all cpus = 0.

Signed-off-by: Mike Travis <travis@sgi.com>
---
 arch/x86/kernel/smpboot_64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -141,8 +141,8 @@ static void __cpuinit smp_store_cpu_info
 	struct cpuinfo_x86 *c = &cpu_data(id);
 
 	*c = boot_cpu_data;
-	c->cpu_index = id;
 	identify_cpu(c);
+	c->cpu_index = id;
 	print_cpu_info(c);
 }
 

-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-12-18 23:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-18 23:37 [PATCH 0/1] x86: fix show cpuinfo cpu number always zero travis
2007-12-18 23:37 ` [PATCH 1/1] " travis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox