Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

Tejun Heo
2007-12-09T07:00:21Z

Hello, (cc'ing Alan)

Andrew Morton wrote:
>> Subject : cd/dvd inaccessible in 2.6.24-rc2
>> Submitter : Will Trives <will@trivescon.com.au>
>> References : http://lkml.org/lkml/2007/11/9/290
>> http://bugzilla.kernel.org/show_bug.cgi?id=9346
>> Handled-By : Len Brown <lenb@kernel.org>
>> Tejun Heo <htejun@gmail.com>
>> Patch :
>>
>
> Nasty one. Tejun and several diligent reporters are doing sterling
> work there and things have improved. I don't know whether any of
> Tejun's patches have been merged yet, but we'll probably be OK on
> this one.

I'm still trying to find out what's really going on. That drive is
quite peculiar.

> What is unclear (to me) is what actually caused those people's machines to
> break?

It's introduced by setting ATAPI transfer chunk size to actual
transfer size which is the right thing to do generally. However, with
the change, the ATAPI HSM should be ready to drain full extra transfer
chunks which libata HSM wasn't doing. With that part changed, most
regressions should go away.

Unfortunately, simply adding that doesn't fix the case in bug 9346 and
I'm still trying to find out why. The good news is that the drive
works fine with proposed more extensive improvements to libata ATAPI
which will probably be included into 2.6.25, so we at least have long
term solution.

If we fail to find out the solution in time, we always have the
alternative of backing out the ATAPI transfer chunk size update. This
will break some other cases which were fixed by the change but those
won't be regressions at least and we can add transfer chunk size
update with other changes to 2.6.25.

Thanks.

--
tejun