Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2.6.24-rc4-git5: Reported regressions from 2.6.23]

Linus Torvalds
2007-12-08T18:38:38Z

On Sat, 8 Dec 2007, Andrew Morton wrote:
>
> > So which warning is it that triggers the bogus error?
>
> It's a kmap_atomic() debugging patch which I wrote ages ago and whcih Ingo
> sucked into his tree. I don't _think_ this warning is present in your tree
> at all.

Ok, that explains it.

> Knocking out __GFP_ZERO at the point where the slab allocator(s) call the
> page allocator seems like a good approach to me.
>
> But I don't think we need to do anything for 2.6.24..

Good. Although we should perhaps look at that reported performance problem
with SLUB. It looks like SLUB will do a memclear() for the area twice
(first for the whole page, then for the thing it allocated) for the slow
case. Maybe that exacerbates the problem.

Linus