From: Jean Delvare <khali@linux-fr.org>
To: Steve Hardy <steve@linuxrealtime.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D
Date: Wed, 19 Dec 2007 15:54:12 +0100 [thread overview]
Message-ID: <20071219155412.4519fb43@hyperion.delvare> (raw)
In-Reply-To: <4768340C.60208@linuxrealtime.co.uk>
Hi Steve, Andrew,
Thanks for the review Andrew. I have some more comments, I'll reply to
the original post.
On Tue, 18 Dec 2007 20:56:44 +0000, Steve Hardy wrote:
> >> +static int ads7828_attach_adapter(struct i2c_adapter *adapter)
> >> +{
> >> + if (!(adapter->class & I2C_CLASS_HWMON))
> >> + return 0;
> >
> > Can this happen?
>
> Hmmm, this code exists in pretty much all of the other hwmon
> drivers, so I will leave it in.
>
> I think it relates to I2C vs ISA connected devices, to avoid
> detecting something with the correct ID on the wrong bus?
Not at all ;) It relates to I2C buses being used in various devices
such as TV adapters, which do not have hardware monitoring chips and do
not like being randomly probed for I2C devices as most hardware
monitoring drivers do when you load them.
--
Jean Delvare
next prev parent reply other threads:[~2007-12-19 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 17:59 [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D Steve Hardy
2007-12-12 10:25 ` Andrew Morton
2007-12-18 20:56 ` Steve Hardy
2007-12-19 14:54 ` Jean Delvare [this message]
2007-12-19 15:35 ` Jean Delvare
[not found] <477D50CC.6020504@linuxrealtime.co.uk>
2008-01-04 7:34 ` Steve Hardy
2008-01-10 0:30 ` Andrew Morton
2008-01-10 13:19 ` Jean Delvare
2008-01-14 22:28 ` Steve Hardy
2008-01-15 10:31 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071219155412.4519fb43@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=steve@linuxrealtime.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox