From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Marc Pignat <marc.pignat@hevs.ch>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH] sdio: move temporary buffer
Date: Wed, 19 Dec 2007 17:57:08 +0100 [thread overview]
Message-ID: <20071219175708.46c781ac@poseidon.drzeus.cx> (raw)
In-Reply-To: <200712191155.26594.marc.pignat@hevs.ch>
On Wed, 19 Dec 2007 11:55:25 +0100
Marc Pignat <marc.pignat@hevs.ch> wrote:
> Move the temporary buffer used by some sdio functions from sdio_func struct to
> the mmc_host struct and make it dma-safe.
>
> Signed-off-by: Marc Pignat <marc.pignat@hevs.ch>
> ---
>
> There is no need to have this temporary buffer in every sdio_func, since all
> access to it are serialized by sdio_[claim/release]_host.
>
I had some crazy idea about per function locking, but until that time this will do just fine.
> I also think it should be ____cacheline_aligned to make sure we have no data
> loss when doing dma syncing operations.
This is still voodoo to me, so I'll have to take your word for it. :)
>
> Comments welcome!
>
Looks good to me.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2007-12-19 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 10:55 [RFC, PATCH] sdio: move temporary buffer Marc Pignat
2007-12-19 16:57 ` Pierre Ossman [this message]
2007-12-20 7:24 ` Marc Pignat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071219175708.46c781ac@poseidon.drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.pignat@hevs.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox