From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Andi Kleen <ak@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Glauber de Oliveira Costa <glommer@gmail.com>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH 0/5] x86: another attempt at x86 pagetable unification
Date: Thu, 20 Dec 2007 23:24:29 +0100 [thread overview]
Message-ID: <20071220222429.GA28029@elte.hu> (raw)
In-Reply-To: <476AE7D6.9000600@goop.org>
* Jeremy Fitzhardinge <jeremy@goop.org> wrote:
> But byte-for-byte identity isn't (necessarily) possible when actually
> unifying. If the same function exists in different forms on 32- and
> 64-bit, then unifying requires I pick one of them (or perhaps a new
> superset) to use in the unified form. That function may generate
> different code compared to the one that it replaced...
it's still possible: you can do preparatory patches that bring one
architecture in sync with the other one, in small, per function steps.
Then the actual unification is still an identity transformation. (and
all the preparatory patches are small and bisectable)
it's also a lot less frustrating and a lot more enjoyable that way IMO.
If it's 50 small patches, then so be it ... 50 patches only take ~2
seconds more for me to apply to x86.git (which time is immediately saved
by the vastly improved reviewability and testability of a 50 patches
set), so dont worry about any overhead on the maintainers side. And
you'll end up moving up on the v2.6.25 contributors top-list on LWN as
well ;-) The worst aspect of it is writing up the 50 changelogs (i use
pre-created templates for that) and figuring out how to script a
patch-bomb to lkml. In every other aspect it's a win-win scenario for
everyone involved.
Ingo
next prev parent reply other threads:[~2007-12-20 22:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 22:35 [PATCH 0/5] x86: another attempt at x86 pagetable unification Jeremy Fitzhardinge
2007-12-19 22:35 ` [PATCH 1/5] x86: clean up asm-x86/page*.h Jeremy Fitzhardinge
2007-12-19 22:35 ` [PATCH 2/5] x86: unify pgtable*.h Jeremy Fitzhardinge
2007-12-20 12:19 ` Eduardo Habkost
2007-12-20 21:02 ` Jeremy Fitzhardinge
2007-12-19 22:35 ` [PATCH 3/5] x86: fix up formatting in pgtable*.h Jeremy Fitzhardinge
2007-12-19 22:35 ` [PATCH 4/5] x86: use a uniform structure for pte_t Jeremy Fitzhardinge
2007-12-19 22:35 ` [PATCH 5/5] x86: clean up pagetable-related printk format warnings Jeremy Fitzhardinge
2007-12-20 9:13 ` [PATCH 0/5] x86: another attempt at x86 pagetable unification Ingo Molnar
2007-12-20 9:49 ` Ingo Molnar
2007-12-20 11:20 ` Ingo Molnar
2007-12-20 21:08 ` Jeremy Fitzhardinge
2007-12-20 21:39 ` Ingo Molnar
2007-12-20 22:08 ` Jeremy Fitzhardinge
2007-12-20 22:24 ` Ingo Molnar [this message]
2007-12-21 0:52 ` Jeremy Fitzhardinge
2007-12-21 0:58 ` Ingo Molnar
2007-12-21 1:03 ` Glauber de Oliveira Costa
2007-12-20 21:03 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220222429.GA28029@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=glommer@gmail.com \
--cc=jbeulich@novell.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox