From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: akpm@linux-foundation.org, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@muc.de>,
Chuck Ebbert <cebbert@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [patch 14/24] Immediate Values - x86 Optimization
Date: Thu, 20 Dec 2007 22:19:01 -0500 [thread overview]
Message-ID: <20071221031900.GA2414@Krystal> (raw)
In-Reply-To: <476B2B5E.5060204@zytor.com>
* H. Peter Anvin (hpa@zytor.com) wrote:
> This patch is modified by another patch in the sequence. This feels
> needlessly confusing when reviewing (especially since the comment doesn't
> look to match the code, e.g. w.r.t to "Q" and "R" constraints); can you
> reorder the patchset to avoid that?
>
Argh.. Rusty asked to have a simplified version first, and then to
implement the "more complex" one on top of it. However, in order to get
the reentrancy I need for the markers, I need the complex version of the
immediate values. Therefore, you find, in this patchset, the simple
version first, and then, the more complex one implemented on top.
About this patch header, the initial idea was to use the "Q" and "R"
constraints, but, as stated just below, the "q" and "r" constraints are
used instead to make sure the REX prefixed opcodes for 1, 2, and 4 bytes
immediate values are never used. So the complete header follows the
source code, it's just that this paragraph could be clearer.
Mathieu
> -hpa
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-12-21 3:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 1:54 [patch 00/24] Markers use immediate values, for 2.6.24-rc5-mm1 Mathieu Desnoyers
2007-12-21 1:54 ` [patch 01/24] Kprobes - use a mutex to protect the instruction pages list Mathieu Desnoyers
2007-12-21 1:54 ` [patch 02/24] Kprobes - do not use kprobes mutex in arch code Mathieu Desnoyers
2007-12-21 1:54 ` [patch 03/24] Kprobes - declare kprobe_mutex static Mathieu Desnoyers
2007-12-21 1:54 ` [patch 04/24] Add INIT_ARRAY() to kernel.h Mathieu Desnoyers
2007-12-21 1:54 ` [patch 05/24] Text Edit Lock - Architecture Independent Code Mathieu Desnoyers
2007-12-21 5:18 ` zhangxiliang
2007-12-21 6:01 ` zhangxiliang
2007-12-21 13:46 ` Mathieu Desnoyers
2007-12-21 1:54 ` [patch 06/24] Text Edit Lock - Alternative code for x86 Mathieu Desnoyers
2007-12-21 1:54 ` [patch 07/24] Text Edit Lock - kprobes architecture independent support Mathieu Desnoyers
2007-12-21 1:54 ` [patch 08/24] Text Edit Lock - kprobes x86_32 Mathieu Desnoyers
2007-12-21 1:54 ` [patch 09/24] Text Edit Lock - kprobes x86_64 Mathieu Desnoyers
2007-12-21 1:54 ` [patch 10/24] Text Edit Lock - x86_32 standardize debug rodata Mathieu Desnoyers
2007-12-21 1:54 ` [patch 11/24] Text Edit Lock - x86_64 " Mathieu Desnoyers
2007-12-21 1:54 ` [patch 12/24] Immediate Values - Architecture Independent Code Mathieu Desnoyers
2007-12-21 1:54 ` [patch 13/24] Immediate Values - Kconfig menu in EMBEDDED Mathieu Desnoyers
2007-12-21 1:54 ` [patch 14/24] Immediate Values - x86 Optimization Mathieu Desnoyers
2007-12-21 2:56 ` H. Peter Anvin
2007-12-21 3:19 ` Mathieu Desnoyers [this message]
2007-12-21 3:30 ` H. Peter Anvin
2007-12-21 13:16 ` [patch 14/24] Immediate Values - x86 Optimization (updated) Mathieu Desnoyers
2007-12-21 13:19 ` Mathieu Desnoyers
2007-12-21 1:54 ` [patch 15/24] Add text_poke and sync_core to powerpc Mathieu Desnoyers
2007-12-21 1:54 ` [patch 16/24] Immediate Values - Powerpc Optimization Mathieu Desnoyers
2007-12-21 1:54 ` [patch 17/24] Immediate Values - Documentation Mathieu Desnoyers
2007-12-21 1:54 ` [patch 18/24] Scheduler Profiling - Use Immediate Values Mathieu Desnoyers
2007-12-21 1:54 ` [patch 19/24] Immediate Values - Move Kprobes x86 restore_interrupt to kdebug.h Mathieu Desnoyers
2007-12-21 1:54 ` [patch 20/24] Add __discard section to x86 Mathieu Desnoyers
2007-12-21 1:54 ` [patch 21/24] Immediate Values - x86 Optimization NMI and MCE support Mathieu Desnoyers
2007-12-21 13:25 ` [patch 21/24] Immediate Values - x86 Optimization NMI and MCE support (updated) Mathieu Desnoyers
2007-12-21 1:55 ` [patch 22/24] Immediate Values - Powerpc Optimization NMI MCE support Mathieu Desnoyers
2007-12-21 1:55 ` [patch 23/24] Immediate Values Use Arch NMI and MCE Support Mathieu Desnoyers
2007-12-21 1:55 ` [patch 24/24] Linux Kernel Markers - Use Immediate Values Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221031900.GA2414@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=ak@muc.de \
--cc=akpm@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox