Re: [PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

Jan Engelhardt
2007-12-17T23:21:52Z

On Dec 16 2007 18:50, Paul Mundt wrote:
>On Sun, Dec 16, 2007 at 12:21:21AM +0000, Adrian McMenamin wrote:
>> +/* GD Rom registers */
>> +#define GDROM_BASE_REG 0xA05F7000
>> +#define GDROM_ALTSTATUS_REG GDROM_BASE_REG + 0x18
>> +#define GDROM_DATA_REG GDROM_BASE_REG + 0x80
>> +#define GDROM_ERROR_REG GDROM_BASE_REG + 0x84
>> +#define GDROM_INTSEC_REG GDROM_BASE_REG + 0x88
>> +#define GDROM_SECNUM_REG GDROM_BASE_REG + 0x8C
>> +#define GDROM_BCL_REG GDROM_BASE_REG + 0x90
>> +#define GDROM_BCH_REG GDROM_BASE_REG + 0x94
>> +#define GDROM_DSEL_REG GDROM_BASE_REG + 0x98
>> +#define GDROM_STATUSCOMMAND_REG GDROM_BASE_REG + 0x9C
>> +#define GDROM_RESET_REG GDROM_BASE_REG + 0x4E4
>> +
>> +#define GDROM_DATA_REG_P0 0x005F7080
>> +
>> +#define GDROM_DMA_STARTADDR_REG GDROM_BASE_REG + 0x404
>> +#define GDROM_DMA_LENGTH_REG GDROM_BASE_REG + 0x408
>> +#define GDROM_DMA_DIRECTION_REG GDROM_BASE_REG + 0x40C
>> +#define GDROM_DMA_ENABLE_REG GDROM_BASE_REG + 0x414
>> +#define GDROM_DMA_STATUS_REG GDROM_BASE_REG + 0x418
>> +#define GDROM_DMA_WAIT_REG GDROM_BASE_REG + 0x4A0
>> +#define GDROM_DMA_ACCESS_CTRL_REG GDROM_BASE_REG + 0x4B8
>> +
>These should all be encapsulated by brackets.

Or making it an enum {
GDROM_DMA_ACCESS_CTL_REG = GDROM_BASE_REG + 0x4B8,
}; without brackets.