public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Yuusei KUWANA <kuwana@nyanyan.to>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	mikael.starvik@axis.com
Subject: Re: [PATCH] arch/cris/arch-v10/vmlinux.lds.S fix boot problem
Date: Sat, 22 Dec 2007 09:37:17 +0100	[thread overview]
Message-ID: <20071222083717.GB22653@uranus.ravnborg.org> (raw)
In-Reply-To: <20071221160718.GO10888@axis.com>

Hi Jesper.

>  		__initramfs_end = .;
> -		/* We fill to the next page, so we can discard all init
> -		   pages without needing to consider what payload might be
> -		   appended to the kernel image.  */
> -		FILL (0); 
> -		. = ALIGN (8192);
>  	}
>  #endif
> -	
>  	__vmlinux_end = .;            /* last address of the physical file */
> -  	__init_end = .;
> +
> +	/*
> +	 * We fill to the next page, so we can discard all init
> +	 * pages without needing to consider what payload might be
> +	 * appended to the kernel image.
> +	 */
> +	.init.fill : {
> +		FILL (0);
> +		. = ALIGN (8192);
> +	}
> +
> +	__init_end = .;

Can we please have the hardcoded 8192 replaced with a proper constant.
I assume this is PAGESIZE?
See hwat other archs does to make PAGESIZE available for assembly
files and ldscripts. The macro AC is the key point here.

And then please explain why it make a diffrence to put the
alignment in a section like you do.
I do not see it used in the other archs.

	Sam

  reply	other threads:[~2007-12-22  8:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-15  5:59 [PATCH] arch/cris/arch-v10/vmlinux.lds.S fix boot problem Yuusei KUWANA
2007-12-21 15:14 ` Jesper Nilsson
2007-12-21 15:54   ` Jesper Nilsson
2007-12-21 16:07     ` Jesper Nilsson
2007-12-22  8:37       ` Sam Ravnborg [this message]
2008-01-03 17:02         ` Jesper Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071222083717.GB22653@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=jesper.nilsson@axis.com \
    --cc=kuwana@nyanyan.to \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikael.starvik@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox