From: Sam Ravnborg <sam@ravnborg.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
trivial@kernel.org, Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH 1/3] Remove unused dependency
Date: Sat, 22 Dec 2007 15:31:28 +0100 [thread overview]
Message-ID: <20071222143128.GA24659@uranus.ravnborg.org> (raw)
In-Reply-To: <1198313412.4895.24.camel@localhost>
On Sat, Dec 22, 2007 at 12:50:12AM -0800, Joe Perches wrote:
> On Sat, 2007-12-22 at 09:33 +0100, Sam Ravnborg wrote:
> > arch/alpha/boot/mixc.c have:
> > #include "../../../lib/inflate.c"
>
> Right. thanks. Sorry for the noise.
It was the removal of the file I objected against - not thremoval of the
dependency.
kbuild will find the dpendency as expressed in the Makefile
all by itself.
>
> Should the makefiles for the sources that include lib/inflate.c
> have a dependency similar to arm and alpha?
>
> With:
> arch/alpha/boot/misc.c
> arch/arm/boot/compressed/misc.c
>
> Without:
> arch/cris/arch-v10/boot/compressed/misc.c
> arch/cris/arch-v32/boot/compressed/misc.c
> arch/h8300/boot/compressed/misc.c
> arch/m32r/boot/compressed/misc.c
> arch/sh/boot/compressed/misc.c
> arch/sh64/boot/compressed/misc.c
> arch/x86/boot/compressed/misc_32.c
> arch/x86/boot/compressed/misc_64.c
> init/do_mounts_rd.c
> init/initramfs.c
>
I looked at how inflate was used:
$ grep inflate */boot/Makefile
alpha/boot/Makefile:$(obj)/misc.o: lib/inflate.c
=> redundandt dependency, can be deleted
powerpc/boot/Makefile:zlib := inffast.c inflate.c inftrees.c
powerpc/boot/Makefile:zlibheader := inffast.h inffixed.h inflate.h inftrees.h infutil.h
powerpc/boot/Makefile:$(addprefix $(obj)/,$(zlib)): $(obj)/%: $(srctree)/lib/zlib_inflate/%
powerpc/boot/Makefile:$(addprefix $(obj)/,$(zlibheader)): $(obj)/%: $(srctree)/lib/zlib_inflate/%
=> I could not see why powerpc had to do so much special magic to
get a working zlib - other archs has less troubles...
Did not llok at all archs but some other had funny stuff to use inflate
and friends too. A cleanup of all this is needed.
Sam
next prev parent reply other threads:[~2007-12-22 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 7:02 [PATCH 0/3] Remove lib/inflate.c Joe Perches
2007-12-22 7:02 ` [PATCH 1/3] Remove unused dependency Joe Perches
2007-12-22 7:02 ` [PATCH 2/3] " Joe Perches
2007-12-22 7:02 ` [PATCH 3/3] Remove lib/inflate.c Joe Perches
2007-12-22 8:33 ` [PATCH 1/3] Remove unused dependency Sam Ravnborg
2007-12-22 8:50 ` Joe Perches
2007-12-22 14:31 ` Sam Ravnborg [this message]
2007-12-22 19:28 ` Joe Perches
2007-12-30 22:00 ` Sam Ravnborg
2007-12-31 0:16 ` Joe Perches
2007-12-31 8:20 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071222143128.GA24659@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=ink@jurassic.park.msu.ru \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox