public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PATCH] driver core fix for 2.6.24-rc6
@ 2007-12-23  7:24 Greg KH
  2007-12-23  7:27 ` [PATCH 1/2] UIO: Add a MAINTAINERS entry for Userspace I/O Greg Kroah-Hartman
  2007-12-23  7:27 ` [PATCH 2/2] Modules: fix memory leak of module names Greg Kroah-Hartman
  0 siblings, 2 replies; 3+ messages in thread
From: Greg KH @ 2007-12-23  7:24 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton; +Cc: linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 737 bytes --]

Here is one bugfix for a memory leak for every module that is unloaded
from the system due to the change in the kobject name code against your
2.6.24-rc6 tree.

And an entry for MAINTAINERS for the UIO subsystem so the proper people
get the blame :)

Please pull from:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/driver-2.6.git/

Patches will be sent as a follow-on to this message to lkml for people
to see.

thanks,

greg k-h

------------

 MAINTAINERS     |    8 ++++++++
 kernel/params.c |   10 ++++++++++
 2 files changed, 18 insertions(+), 0 deletions(-)

---------------

Greg Kroah-Hartman (1):
      Modules: fix memory leak of module names

Hans-Jürgen Koch (1):
      UIO: Add a MAINTAINERS entry for Userspace I/O


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] UIO: Add a MAINTAINERS entry for Userspace I/O
  2007-12-23  7:24 [GIT PATCH] driver core fix for 2.6.24-rc6 Greg KH
@ 2007-12-23  7:27 ` Greg Kroah-Hartman
  2007-12-23  7:27 ` [PATCH 2/2] Modules: fix memory leak of module names Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2007-12-23  7:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Hans-Jürgen Koch, Greg Kroah-Hartman

From: Hans-Jürgen Koch <hjk@linutronix.de>

This patch adds an entry for the Userspace I/O framework to MAINTAINERS.

Signed-off-by: Hans J. Koch <hjk@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 MAINTAINERS |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3c7db62..a06ee43 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4054,6 +4054,14 @@ L:	user-mode-linux-user@lists.sourceforge.net
 W:	http://user-mode-linux.sourceforge.net
 S:	Maintained
 
+USERSPACE I/O (UIO)
+P:	Hans J. Koch
+M:	hjk@linutronix.de
+P:	Greg Kroah-Hartman
+M:	gregkh@suse.de
+L:	linux-kernel@vger.kernel.org
+S:	Maintained
+
 FAT/VFAT/MSDOS FILESYSTEM:
 P:	OGAWA Hirofumi
 M:	hirofumi@mail.parknet.co.jp
-- 
1.5.3.7


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] Modules: fix memory leak of module names
  2007-12-23  7:24 [GIT PATCH] driver core fix for 2.6.24-rc6 Greg KH
  2007-12-23  7:27 ` [PATCH 1/2] UIO: Add a MAINTAINERS entry for Userspace I/O Greg Kroah-Hartman
@ 2007-12-23  7:27 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2007-12-23  7:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Kroah-Hartman, Alexey Dobriyan, Kay Sievers

Due to the change in kobject name handling, the module kobject needs to
have a null release function to ensure that the name it previously set
will be properly cleaned up.

All of this wierdness goes away in 2.6.25 with the rework of the kobject
name and cleanup logic, but this is required for 2.6.24.

Thanks to Alexey Dobriyan for finding the problem, and to Kay Sievers
for pointing out the simple way to fix it after I tried many complex
ways.

Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 kernel/params.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index 2a4c514..7686417 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -697,8 +697,18 @@ static struct kset_uevent_ops module_uevent_ops = {
 decl_subsys(module, &module_ktype, &module_uevent_ops);
 int module_sysfs_initialized;
 
+static void module_release(struct kobject *kobj)
+{
+	/*
+	 * Stupid empty release function to allow the memory for the kobject to
+	 * be properly cleaned up.  This will not need to be present for 2.6.25
+	 * with the upcoming kobject core rework.
+	 */
+}
+
 static struct kobj_type module_ktype = {
 	.sysfs_ops =	&module_sysfs_ops,
+	.release =	module_release,
 };
 
 /*
-- 
1.5.3.7


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-12-23  7:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-23  7:24 [GIT PATCH] driver core fix for 2.6.24-rc6 Greg KH
2007-12-23  7:27 ` [PATCH 1/2] UIO: Add a MAINTAINERS entry for Userspace I/O Greg Kroah-Hartman
2007-12-23  7:27 ` [PATCH 2/2] Modules: fix memory leak of module names Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox