From: Ingo Molnar <mingo@elte.hu>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: travis@sgi.com, LKML <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, suresh.b.siddha@intel.com,
venkatesh.pallipadi@intel.com, Yinghai.Lu@Sun.COM
Subject: Re: volanoMark 24% regression in 2.6.24-rc6: why a simple patch makes it
Date: Tue, 25 Dec 2007 09:25:56 +0100 [thread overview]
Message-ID: <20071225082556.GA26342@elte.hu> (raw)
In-Reply-To: <1198559645.6362.195.camel@ymzhang>
* Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:
> The solution is just to revert patch
> fbdcf18df73758b2e187ab94678b30cd5f6ff9f9, because other 2 patches
> which fixed the same issue are already in 2.6.24-rc5.
Linus, please revert fbdcf18df73758, as requested by Yanmin. It was
noticed before (by Yinghai Lu) that this commit was not needed, but it
looked a harmless duplication and we incorrectly thought it's only a NOP
and wanted to fix it in v2.6.25 - but as Yanmin has analyzed it now, it
creates a sub-optimal sched-domains hierarchy (not setting up the domain
belonging to the core) when CONFIG_X86_HT=y.
Acked-by: Ingo Molnar <mingo@elte.hu>
nice work Yanmin!
Ingo
prev parent reply other threads:[~2007-12-25 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-25 5:14 volanoMark 24% regression in 2.6.24-rc6: why a simple patch makes it Zhang, Yanmin
2007-12-25 8:25 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225082556.GA26342@elte.hu \
--to=mingo@elte.hu \
--cc=Yinghai.Lu@Sun.COM \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
--cc=venkatesh.pallipadi@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox