From: Christoph Hellwig <hch@infradead.org>
To: marcin.slusarz@gmail.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Ben Fennema <bfennema@falcon.csc.calpoly.edu>,
Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/6] udf: remove some ugly macros
Date: Tue, 25 Dec 2007 11:54:38 +0000 [thread overview]
Message-ID: <20071225115438.GA8296@infradead.org> (raw)
In-Reply-To: <1198455022-27674-3-git-send-email-marcin.slusarz@gmail.com>
Looks generally good, but it would be nice if you could avoid
introducing new overly long lines. Then again this really won't be
noticed in udf anyway and it looks like you plan to clean it up later
anyway.
(in case it wasn;'t clear count this as an ack from me)
next prev parent reply other threads:[~2007-12-25 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 0:10 [PATCH 0/6] udf: improve code related to super_block, was: udf: convert super_block macros to functions marcin.slusarz
2007-12-24 0:10 ` [PATCH 1/6] udf: fix coding style of super.c marcin.slusarz
2007-12-24 0:10 ` [PATCH 2/6] udf: remove some ugly macros marcin.slusarz
2007-12-25 11:54 ` Christoph Hellwig [this message]
2007-12-25 14:45 ` Marcin Slusarz
2007-12-24 0:10 ` [PATCH 3/6] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function marcin.slusarz
2007-12-25 11:59 ` Christoph Hellwig
2007-12-25 15:13 ` Marcin Slusarz
2007-12-25 16:41 ` Christoph Hellwig
2007-12-24 0:10 ` [PATCH 4/6] udf: check if udf_load_logicalvol failed marcin.slusarz
2007-12-24 0:10 ` [PATCH 5/6] udf: convert some macros to functions marcin.slusarz
2007-12-24 0:10 ` [PATCH 6/6] udf: fix sparse warnings (shadowing & mismatch between declaration and definition) marcin.slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225115438.GA8296@infradead.org \
--to=hch@infradead.org \
--cc=bfennema@falcon.csc.calpoly.edu \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox