From: Andy Whitcroft <apw@shadowen.org>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: checkpatch false ERROR: trailing statements should be on next line
Date: Wed, 26 Dec 2007 13:02:58 +0000 [thread overview]
Message-ID: <20071226130258.GC8346@shadowen.org> (raw)
In-Reply-To: <200712252150.lBPLo4wG031988@agora.fsl.cs.sunysb.edu>
On Tue, Dec 25, 2007 at 04:50:04PM -0500, Erez Zadok wrote:
> Using v2.6.24-rc6-125-g5356f66, code such as this:
>
> if (is_file) /* dirs can be unlinked but chdir'ed to */
> err = -ESTALE;
>
> produces this false checkpatch error:
>
> foo.c:947: ERROR: trailing statements should be on next line
>
> I think comments such as the above should be allowed (plus a comment isn't a
> statement). It's often very useful to put them right on the affected line.
Agreed. checkpatch 0.13 already ignores these as statements. A
positive side effect of other changes in this area.
Thanks for the report.
-apw
prev parent reply other threads:[~2007-12-26 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-25 21:50 checkpatch false ERROR: trailing statements should be on next line Erez Zadok
2007-12-26 13:02 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071226130258.GC8346@shadowen.org \
--to=apw@shadowen.org \
--cc=ezk@cs.sunysb.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox