From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Adrian McMenamin <lkmladrian@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: Correct use of __init and __devinit
Date: Wed, 26 Dec 2007 23:50:12 +0100 [thread overview]
Message-ID: <20071226235012.04373e0d@siona> (raw)
In-Reply-To: <20071224130143.GA27530@uranus.ravnborg.org>
On Mon, 24 Dec 2007 14:01:43 +0100
Sam Ravnborg <sam@ravnborg.org> wrote:
> So of the principle of least suprise it is best to use __devinit
> for the probe function as most other drivers do. And if
> the driver model happens to call your probe function after
> init time then we will not oops.
If you're dealing with platform_devices, you can use
platform_driver_probe() and remove the probe() function from the
platform_driver struct to ensure this never happens.
This is only ok for non-hotpluggable devices, of course.
Haavard
prev parent reply other threads:[~2007-12-26 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-23 16:56 Correct use of __init and __devinit Adrian McMenamin
2007-12-24 13:01 ` Sam Ravnborg
2007-12-26 22:50 ` Haavard Skinnemoen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071226235012.04373e0d@siona \
--to=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmladrian@gmail.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox