Re: Major regression on hackbench with SLUB (more numbers)

Christoph Lameter
2007-12-21T23:54:43Z

On Sat, 22 Dec 2007, Ingo Molnar wrote:

> and the regression seems to be largely fixed! Not only is the hackbench
> one fixed, but mmap shows an above-noise improvement as well.
>
> Acked-by: Ingo Molnar <mingo@elte.hu>

Well lets use the version attached to this patch. It turns out that it is
not important to increase the number of partial slabs. Just putting the
slab onto the tail of the list does it.

> And i hereby nominate Pekka as SLUB/SLAB co-maintainer and spokesperson
> ;-)

He is already the co-maintainer of the slab allocators. See the
MAINTAINERS file.

SLUB: Improve hackbench speed

Increase the mininum number of partial slabs to keep around and put
partial slabs to the end of the partial queue so that they can add
more objects.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
mm/slub.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c 2007-12-21 14:30:11.096324462 -0800
+++ linux-2.6/mm/slub.c 2007-12-21 15:10:17.611022381 -0800
@@ -1611,12 +1611,12 @@ checks_ok:
goto slab_empty;

/*
- * Objects left in the slab. If it
- * was not on the partial list before
- * then add it.
+ * Objects left in the slab. If it was not on the partial list before
+ * then add it. Add it to the end since there is only a single object
+ * which would make slab_alloc inefficient.
*/
if (unlikely(!prior))
- add_partial(get_node(s, page_to_nid(page)), page);
+ add_partial_tail(get_node(s, page_to_nid(page)), page);

out_unlock:
slab_unlock(page);