public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 11/12] spi : Use mutex instead of semaphore in driver core
@ 2007-12-29  1:18 Dave Young
  2007-12-29  1:37 ` David Brownell
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Young @ 2007-12-29  1:18 UTC (permalink / raw)
  To: dbrownell; +Cc: linux-kernel, spi-devel-general

Signed-off-by: Dave Young <hidave.darkstar@gmail.com> 

---
drivers/spi/spi.c |    4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
--- linux/drivers/spi/spi.c	2007-12-28 10:47:38.000000000 +0800
+++ linux.new/drivers/spi/spi.c	2007-12-28 10:48:22.000000000 +0800
@@ -494,7 +494,7 @@ struct spi_master *spi_busnum_to_master(
 	struct spi_master	*master = NULL;
 	struct spi_master	*m;
 
-	down(&spi_master_class.sem);
+	mutex_lock(&spi_master_class.mutex);
 	list_for_each_entry(dev, &spi_master_class.children, node) {
 		m = container_of(dev, struct spi_master, dev);
 		if (m->bus_num == bus_num) {
@@ -502,7 +502,7 @@ struct spi_master *spi_busnum_to_master(
 			break;
 		}
 	}
-	up(&spi_master_class.sem);
+	mutex_unlock(&spi_master_class.mutex);
 	return master;
 }
 EXPORT_SYMBOL_GPL(spi_busnum_to_master);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 11/12] spi : Use mutex instead of semaphore in driver core
  2007-12-29  1:18 [PATCH 11/12] spi : Use mutex instead of semaphore in driver core Dave Young
@ 2007-12-29  1:37 ` David Brownell
  0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2007-12-29  1:37 UTC (permalink / raw)
  To: Dave Young; +Cc: linux-kernel, spi-devel-general

On Friday 28 December 2007, Dave Young wrote:
> Signed-off-by: Dave Young <hidave.darkstar@gmail.com> 

ACK ... if the driver core is changing, this is obvious.
 
> ---
> drivers/spi/spi.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -upr linux/drivers/spi/spi.c linux.new/drivers/spi/spi.c
> --- linux/drivers/spi/spi.c	2007-12-28 10:47:38.000000000 +0800
> +++ linux.new/drivers/spi/spi.c	2007-12-28 10:48:22.000000000 +0800
> @@ -494,7 +494,7 @@ struct spi_master *spi_busnum_to_master(
>  	struct spi_master	*master = NULL;
>  	struct spi_master	*m;
>  
> -	down(&spi_master_class.sem);
> +	mutex_lock(&spi_master_class.mutex);
>  	list_for_each_entry(dev, &spi_master_class.children, node) {
>  		m = container_of(dev, struct spi_master, dev);
>  		if (m->bus_num == bus_num) {
> @@ -502,7 +502,7 @@ struct spi_master *spi_busnum_to_master(
>  			break;
>  		}
>  	}
> -	up(&spi_master_class.sem);
> +	mutex_unlock(&spi_master_class.mutex);
>  	return master;
>  }
>  EXPORT_SYMBOL_GPL(spi_busnum_to_master);
> 



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-12-29  1:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-29  1:18 [PATCH 11/12] spi : Use mutex instead of semaphore in driver core Dave Young
2007-12-29  1:37 ` David Brownell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox