From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Adrian Bunk <adrian.bunk@movial.fi>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
rmk@arm.linux.org.uk, phil.el@wanadoo.fr,
oprofile-list@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [2.6.24 patch] restore ARMv6 OProfile support
Date: Fri, 28 Dec 2007 14:12:00 -0500 [thread overview]
Message-ID: <20071228191159.GA21353@Krystal> (raw)
In-Reply-To: <20071228185636.GA4738@stusta.de>
* Adrian Bunk (adrian.bunk@movial.fi) wrote:
> This patch restores the ARMv6 OProfile support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
>
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
>
Yup, it must be put back, but I doubt stuffing it in
kernel/Kconfig.instrumentation is the best way to proceed, especially
since it will break the "instrumentation menu removal" patches currently
in -mm _and_ because this is arm-specific.
Why don't we simply put it in arch/arm/Kconfig ?
> ---
>
> kernel/Kconfig.instrumentation | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> 7fc221ef169610b5eac98e2ddd641811c0d53e4a
> diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> index 468f47a..4453187 100644
> --- a/kernel/Kconfig.instrumentation
> +++ b/kernel/Kconfig.instrumentation
> @@ -29,2 +29,17 @@ config OPROFILE
>
> +config OPROFILE_ARMV6
> + bool
> + depends on OPROFILE && ARM && CPU_V6 && !SMP
> + default y
> + select OPROFILE_ARM11_CORE
> +
> +config OPROFILE_MPCORE
> + bool
> + depends on OPROFILE && ARM && CPU_V6 && SMP
> + default y
> + select OPROFILE_ARM11_CORE
> +
> +config OPROFILE_ARM11_CORE
> + bool
> +
> config KPROBES
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-12-28 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 18:56 [2.6.24 patch] restore ARMv6 OProfile support Adrian Bunk
2007-12-28 19:12 ` Mathieu Desnoyers [this message]
2007-12-28 19:57 ` Russell King
2007-12-29 16:05 ` [2.6.24 patch] Fix " Mathieu Desnoyers
2007-12-29 18:06 ` Randy Dunlap
2007-12-29 22:00 ` Mathieu Desnoyers
2008-01-02 17:43 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071228191159.GA21353@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=adrian.bunk@movial.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=phil.el@wanadoo.fr \
--cc=randy.dunlap@oracle.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).