public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Adrian Bunk <adrian.bunk@movial.fi>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	bryan.wu@analog.com, linux-kernel@vger.kernel.org
Subject: Re: [2.6.24 patch] restore blackfin HARDWARE_PM support
Date: Fri, 28 Dec 2007 14:14:04 -0500	[thread overview]
Message-ID: <20071228191404.GB21353@Krystal> (raw)
In-Reply-To: <20071228185643.GB4738@stusta.de>

* Adrian Bunk (adrian.bunk@movial.fi) wrote:
> This patch restores the blackfin Hardware Performance Monitor Profiling 
> support that was killed by
> commit 09cadedbdc01f1a4bea1f427d4fb4642eaa19da9.
> 
> Signed-off-by: Adrian Bunk <adrian.bunk@movial.fi>
> 

Yep, this one too must be put back, but kernel/Kconfig.instrumentation
seems like the wrong spot for a blackfin-specific config option (and
this will break the instrumentation menu removal patches in -mm).

Can we put this in arch/blackfin/Kconfig instead ?

> ---
> 
>  kernel/Kconfig.instrumentation |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> 942996f33f81726c5edb012d61ecdad70c55884d 
> diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
> index 97c76ca..e023671 100644
> --- a/kernel/Kconfig.instrumentation
> +++ b/kernel/Kconfig.instrumentation
> @@ -44,2 +44,11 @@ config OPROFILE_MPCORE
>  
> +config HARDWARE_PM
> +	tristate "Hardware Performance Monitor Profiling"
> +	depends on BLACKFIN && PROFILING
> +	help
> +	  take use of hardware performance monitor to profiling the kernel
> +	  and application.
> +
> +	  If unsure, say N.
> +
>  config KPROBES
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2007-12-28 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 18:56 [2.6.24 patch] restore blackfin HARDWARE_PM support Adrian Bunk
2007-12-28 19:14 ` Mathieu Desnoyers [this message]
2007-12-28 19:23   ` Adrian Bunk
2007-12-28 19:28     ` Mathieu Desnoyers
2007-12-29  6:14       ` Robin Getz
2007-12-29  6:23         ` Mathieu Desnoyers
2007-12-29 19:28           ` Robin Getz
2007-12-29 16:29         ` [2.6.24 patch] Fix " Mathieu Desnoyers
2008-01-02 17:46           ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071228191404.GB21353@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=adrian.bunk@movial.fi \
    --cc=akpm@linux-foundation.org \
    --cc=bryan.wu@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox