Re: [PATCH] x86: unify x86 Makefile(s)

Adrian Bunk
2007-12-29T08:07:45Z

On Sat, Dec 29, 2007 at 03:14:23AM +0100, Andi Kleen wrote:
> On Friday 28 December 2007 23:13:24 Adrian Bunk wrote:
> > On Fri, Dec 28, 2007 at 10:23:41PM +0100, Sam Ravnborg wrote:
> > >...
> > > Noteworthy remarks on the unification:
> > >...
> > > - -funit-at-a-time should be easy to unify but it looks like we have a bug
> > > in 32 bit. We only enable -funit-at-a-time for gcc less than 0400 if they
> > > support it
> >
> > No, we _dis_able it on 32bit if a gcc < 4.0 supports it.
> >
> > > (and I recall it is a gcc 4.00 feature). [-lt -> -gt]
> > >...
> >
> > unit-at-a-time was introduced in upstream gcc 3.4 and backported to some
> > popular 3.3 x86_64 branch.
> >
> > i386 and x86_64 go in exactly opposite directions regarding when to use
> > unit-at-a-time, but that was intentional and we should keep it that way.
>
> i386 disabled it because there were claims that it increased stack size
> too much, but I haven't seen any real evidence for that. That is why I never
> added it to x86-64. On the other hand it tends to shrink text size considerably.
>
> I think it should be reevaluated and enabled by default on i386 again.
>
> BTW there is a patch pending for gcc 4.3+ that prevents optimizations
> that increase stack size unduly. Not sure it has been added there yet,
> but that was the right fix for these problems anyways.

We are talking only about gcc 3.4 on i386 - for gcc >= 4.0 or gcc 3.4 on
other architectures we always leave unit-at-a-time enabled.

Considering that:
- there were some problems with gcc 3.4 and i386 4kB stacks,
- gcc 3.4 is ancient (and therefore nothing people who want the fastest
or smallest code should use) and
- the number of i386 gcc 3.4 users is quite low today
we should simply leave it as it is, and all this will anyway
automatically vanish when we'll drop support for gcc < 4.0 a few years
from now.

> -Andi

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed