Re: [PATCH] x86: unify x86 Makefile(s)

Adrian Bunk
2007-12-29T21:45:36Z

On Sat, Dec 29, 2007 at 10:17:37PM +0100, Andi Kleen wrote:
>
> > Until we are on par with stack usage I recommend to keep
> > -fno-unit-at-a-time disabled for gcc less than 4.00 as
> > suggested by Adrian (as is what we have today).
>
> Again the correct fix is to add "noinline" to the functions that are getting
> inlined here in 3.4 but not 4+.

The problem isn't that gcc 3.4 and gcc 4.x inlined different functions,
the problem is that with gcc 3.4 the stack usage was higher.

AFAIR, the problem was roughly something like:

<-- snip -->

static void foo(void)
{
...
}

static void bar(void)
{
...
}

void foobar(void)
{
foo();
bar();
}

<-- snip -->

Without inlining the maxmimum stack usage inside foobar() is
max(stack usage foo(), stack usage bar()). [1]

With foo() and bar() inlined (-funit-at-a-time also enables
-finline-functions-called-once), the maxmimum stack usage inside
foobar() is sum(stack usage foo(), stack usage bar()). And this
worst case is the area where gcc 4 is much better than gcc 3.4.

We have cases in the kernel were a switch handles a dozen cases
(e.g. ioctl handling) and each results in a call to a different static
function.

> -Andi

cu
Adrian

[1] this ignores function call stack usages, but these are low compared
to the interesting ones

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed