public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Greg KH <gregkh@suse.de>, Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 01/12] Use mutex instead of semaphore in driver core
Date: Sat, 29 Dec 2007 09:07:30 -0800	[thread overview]
Message-ID: <20071229170730.GA1351@kroah.com> (raw)
In-Reply-To: <a8e1da0712282307p3723857ex534d787f128db112@mail.gmail.com>

On Sat, Dec 29, 2007 at 03:07:30PM +0800, Dave Young wrote:
> On Dec 29, 2007 1:06 PM, Dave Young <hidave.darkstar@gmail.com> wrote:
> >
> > On Dec 29, 2007 12:42 PM, Greg KH <gregkh@suse.de> wrote:
> > > On Sat, Dec 29, 2007 at 10:36:49AM +0800, Dave Young wrote:
> > > > >
> > > > The full boot dmesg with lockdep output is out, there's one warnings in it :
> > >
> > > Please fix that warning before the next repost of these patches (along
> > > with fixing the problem of them not being able to be applied and
> > > successfully built at every point in the series...)
> > >
> >
> > Ok, thanks, I will fix them and repost.
> >
> 
> Hi,
> After digging the code, I feel hard to fix the lockdep warning due to
> some misterious relationship with usb.
> 
> Could someone help on this? thanks.

My question back to you is why are you doing this conversion?  Have you
found that it is needed for something?  Are there problems in the -rt
kernels that this conversion helps with?  Or is it just a janitorial
"convert semaphore to mutex" type thing.

If the latter, I would suggest dropping it, as this area is quite
complex and I think the locking chain too deep at times for a simple
conversion.

good luck,

greg k-h

  reply	other threads:[~2007-12-29 17:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-29  1:01 [PATCH 01/12] Use mutex instead of semaphore in driver core Dave Young
2007-12-29  1:29 ` Peter Zijlstra
2007-12-29  1:36   ` Dave Young
2007-12-29  1:40     ` Dave Young
2007-12-29  1:42     ` Peter Zijlstra
2007-12-29  1:52       ` Dave Young
2007-12-29  1:57         ` Peter Zijlstra
2007-12-29  2:03           ` Dave Young
2007-12-29  2:36             ` Dave Young
2007-12-29  4:42               ` Greg KH
2007-12-29  5:06                 ` Dave Young
2007-12-29  7:07                   ` Dave Young
2007-12-29 17:07                     ` Greg KH [this message]
2008-01-02  0:54                       ` Dave Young
2008-01-02  5:18                         ` Greg KH
2008-01-02  5:25                           ` David Miller
2008-01-02  7:00                             ` Greg KH
2008-01-02  7:52                               ` David Miller
2008-01-02 12:39                               ` Jarek Poplawski
2008-01-02 13:12                                 ` Jarek Poplawski
2008-01-02 16:08                               ` Alan Stern
2008-01-03  1:00                                 ` Dave Young
2008-01-02  5:37                           ` Dave Young
2007-12-29 22:01                     ` Alan Stern
2007-12-30  6:42                       ` David Brownell
2007-12-30 12:13                         ` Peter Zijlstra
2008-01-08 16:54                         ` Jiri Kosina
2008-01-02  0:58                       ` Dave Young
2008-01-02 16:06                         ` Alan Stern
2008-01-05  9:30           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071229170730.GA1351@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=hidave.darkstar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox