Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

Peter Zijlstra
2007-12-29T01:42:39Z

On Sat, 2007-12-29 at 09:36 +0800, Dave Young wrote:
> On Dec 29, 2007 9:29 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> >
> > I'm pretty sure you didn't boot that kernel with lockdep enabled.
> Yes, I will try rebuild with lockdep and test.

I'll fail miserably :-)

>From your other mail:
> No, I checked the config , lockdep is indeed enabled. But I will try
> to test with the lock debug options enabled in a while.

You need to actually boot the kernel to get effective reports from
lockdep, it'll build just fine.

> > Also, most, if not all, of your patches miss a patch description.
>
> Does the description really needed for it? IMHO, the subject is enough
> to descript the patches.

Preferably, the subject might convey what you are doing, but the full
description should at least add to that by telling _why_ you are doing
that.

Also, I don't think your series is bisectable, ie. 1/12 changes
device::sem -> device::mutex, and 12/12 changes a user of it.