Re: [PATCH 01/12] Use mutex instead of semaphore in driver core

Greg KH
2008-01-02T06:58:54Z

On Tue, Jan 01, 2008 at 09:25:01PM -0800, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Tue, 1 Jan 2008 21:18:28 -0800
>
> > But is the usage of this semaphore in the class code really a problem?
> > Has it been seen to cause issues anywhere? Does it show up on any
> > benchmarks as being something that really needs to be replaced?
>
> It's a question of maintainability and simplicity also Greg.
>
> I actually have no idea why you're making any sort of fuss about this.
> To me it's so clear cut that we should do that.

For most cases, yes, I agree with this, but due to the lockdep issues
that occur here, and the whole mess with the suspend path and locking
the device tree, that has been hashed out many times in the past, I am
interested in trying to see if there is any real reason why this is
absolutely necessary to convert.

If no one has noticed any issues in this area, I think the complexity
that will be involved in any such conversion will strongly outweigh any
simplicity that might be expected.

I'm very open to potential patches to do this, just don't ignore the
issues that others have run into in the past when attempting this.

thanks,

greg k-h