From: Ingo Molnar <mingo@elte.hu>
To: Julia Lawall <julia@diku.dk>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.
Date: Sun, 30 Dec 2007 14:33:35 +0100 [thread overview]
Message-ID: <20071230133335.GA21106@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0712241657080.23999@ask.diku.dk>
* Julia Lawall <julia@diku.dk> wrote:
> On Mon, 24 Dec 2007, Andi Kleen wrote:
>
> > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote:
> > > From: Julia Lawall <julia@diku.dk>
> > >
> > > The functions time_before, time_before_eq, time_after, and time_after_eq
> > > are more robust for comparing jiffies against other values.
> >
> > The old code was actually correct I think, but the change is ok for me.
>
> Please ignore the patch. All of my before_eq and after_eq's are
> backwards due to parsing <= as >= and vice versa. I will try again.
your x86 patches (#7, #8 and #9) do not include any *_eq() comparisons
and they all seem to be correct. So picked those three up into x86.git -
let me know if there's any breakage in them that i missed.
Ingo
next prev parent reply other threads:[~2007-12-30 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 14:23 [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc Julia Lawall
2007-12-24 15:31 ` Andi Kleen
2007-12-24 15:58 ` Julia Lawall
2007-12-30 13:33 ` Ingo Molnar [this message]
2007-12-30 14:55 ` Julia Lawall
2007-12-30 15:41 ` Ingo Molnar
2007-12-30 15:51 ` Julia Lawall
2007-12-30 16:04 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230133335.GA21106@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox