From: Ingo Molnar <mingo@elte.hu>
To: Mike Galbraith <efault@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch?] s2ram + P4 + tsc = annoyance
Date: Sun, 30 Dec 2007 15:04:56 +0100 [thread overview]
Message-ID: <20071230140456.GJ16946@elte.hu> (raw)
In-Reply-To: <1198779574.4425.50.camel@homer.simson.net>
* Mike Galbraith <efault@gmx.de> wrote:
> Or, reset to pristine prior to testing, though that's more lines to
> accomplish the same thing. Either way, or some other way...
>
> If check_tsc_warp() is called after initial boot, and the TSC has in
> the meantime been set (BIOS, user, silicon, elves) to a value lower
> than the last stored/stale value, we blame the TSC. Reset to pristine
> condition after every test.
ok, i prefer this fix a bit more. (we dont want to set last_tsc outside
of the sync_lock - which your initial patch does)
Ingo
next prev parent reply other threads:[~2007-12-30 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-27 8:55 [patch?] s2ram + P4 + tsc = annoyance Mike Galbraith
2007-12-27 18:19 ` Mike Galbraith
2007-12-30 14:04 ` Ingo Molnar [this message]
2007-12-30 14:08 ` Ingo Molnar
2007-12-30 17:42 ` Mike Galbraith
2008-01-04 16:39 ` Pavel Machek
2008-01-04 22:04 ` Mike Galbraith
2008-01-05 9:06 ` Ingo Molnar
[not found] <fa./Gg6lFn4vN7sfhp2nE3LSMDm0q4@ifi.uio.no>
2007-12-27 18:09 ` Robert Hancock
2007-12-27 18:27 ` Mike Galbraith
2007-12-27 18:40 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230140456.GJ16946@elte.hu \
--to=mingo@elte.hu \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox