From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@suse.cz>
Subject: Re: [PATCH] Hibernation: Document __save_processor_state() on x86-64
Date: Sun, 30 Dec 2007 15:21:09 +0100 [thread overview]
Message-ID: <20071230142109.GK16946@elte.hu> (raw)
In-Reply-To: <200712281353.37976.rjw@sisk.pl>
* Rafael J. Wysocki <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Document the fact that __save_processor_state() has to save all CPU
> registers referred to by the kernel in case a different kernel is used
> to load and restore a hibernation image containing it.
ok - so i guess i should drop this from x86.git:
@@ -53,7 +53,6 @@ void __save_processor_state(struct saved
ctxt->cr2 = read_cr2();
ctxt->cr3 = read_cr3();
ctxt->cr4 = read_cr4();
- ctxt->cr8 = read_cr8();
}
right? But i'm wondering - are we really ever resuming to a different
kernel version, for this to be an issue?
Ingo
next prev parent reply other threads:[~2007-12-30 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-28 12:53 [PATCH] Hibernation: Document __save_processor_state() on x86-64 Rafael J. Wysocki
2007-12-29 23:43 ` Pavel Machek
2007-12-30 13:30 ` Rafael J. Wysocki
2007-12-30 20:17 ` Pavel Machek
2007-12-30 14:21 ` Ingo Molnar [this message]
2007-12-30 21:04 ` Rafael J. Wysocki
2007-12-30 20:51 ` Ingo Molnar
2007-12-30 21:48 ` Rafael J. Wysocki
2007-12-30 21:31 ` Ingo Molnar
2007-12-30 22:08 ` Rafael J. Wysocki
2007-12-30 21:57 ` Ingo Molnar
2007-12-30 22:37 ` Rafael J. Wysocki
2007-12-31 10:43 ` Ingo Molnar
2007-12-31 17:57 ` Rafael J. Wysocki
2007-12-31 9:29 ` Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071230142109.GK16946@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox