From: Mike Frysinger <vapier@gentoo.org>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: asm-x86/msr.h for sanitized headers: clean it or punt it
Date: Mon, 31 Dec 2007 00:45:23 -0500 [thread overview]
Message-ID: <200712310045.24069.vapier@gentoo.org> (raw)
The current asm-x86/msr.h does not actually define anything for (!__KERNEL__
&& __i386__). For x86_64, it fails to build due to u32/u64 types being used.
Simply not installing the header seems easiest to me. Otherwise, x86_64 will
need sanitizing and i386 should have things added back, otherwise it's just a
pointless empty header.
Signed-Off-By: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/include/asm-x86/Kbuild b/include/asm-x86/Kbuild
index 12db5a1..6453804 100644
--- a/include/asm-x86/Kbuild
+++ b/include/asm-x86/Kbuild
@@ -4,7 +4,6 @@ header-y += boot.h
header-y += bootparam.h
header-y += debugreg.h
header-y += ldt.h
-header-y += msr-index.h
header-y += prctl.h
header-y += ptrace-abi.h
header-y += sigcontext32.h
@@ -14,7 +13,6 @@ header-y += vsyscall32.h
unifdef-y += e820.h
unifdef-y += ist.h
unifdef-y += mce.h
-unifdef-y += msr.h
unifdef-y += mtrr.h
unifdef-y += page_32.h
unifdef-y += page_64.h
next reply other threads:[~2007-12-31 5:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 5:45 Mike Frysinger [this message]
2007-12-31 5:51 ` asm-x86/msr.h for sanitized headers: clean it or punt it H. Peter Anvin
2007-12-31 12:26 ` Andi Kleen
2007-12-31 15:33 ` Mike Frysinger
2007-12-31 16:36 ` Andi Kleen
2007-12-31 18:10 ` Mike Frysinger
2007-12-31 18:15 ` H. Peter Anvin
2007-12-31 18:49 ` Mike Frysinger
2008-01-01 15:47 ` Ingo Molnar
2008-01-02 1:20 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712310045.24069.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox