From: Christoph Hellwig <hch@infradead.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
ocfs2-devel@oss.oracle.com, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core
Date: Mon, 31 Dec 2007 09:17:32 +0000 [thread overview]
Message-ID: <20071231091732.GA29043@infradead.org> (raw)
In-Reply-To: <20071230214857.GA14177@joi>
On Sun, Dec 30, 2007 at 10:49:34PM +0100, Marcin Slusarz wrote:
> I found it in XFS only. Did I miss something?
These helpers come from ocfs2 which has both be and le variants.
> be32_add is shorter than be32_add_cpu but I think it's not clear
> whether second parameter is in native byte order or not.
Then again adding foreing endian values doesn't make much sense.
If you insist on your naming please make sure to convert ocfs and xfs
to your naming.
next prev parent reply other threads:[~2007-12-31 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 19:06 [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Marcin Slusarz
2007-12-30 19:18 ` Christoph Hellwig
2007-12-30 21:49 ` Marcin Slusarz
2007-12-31 9:17 ` Christoph Hellwig [this message]
2007-12-31 19:41 ` Mark Fasheh
2007-12-31 19:38 ` Mark Fasheh
2007-12-31 20:05 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071231091732.GA29043@infradead.org \
--to=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox