From: Mark Fasheh <mark.fasheh@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>,
ocfs2-devel@oss.oracle.com, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core
Date: Mon, 31 Dec 2007 11:41:46 -0800 [thread overview]
Message-ID: <20071231194146.GT13821@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20071231091732.GA29043@infradead.org>
On Mon, Dec 31, 2007 at 09:17:32AM +0000, Christoph Hellwig wrote:
> > be32_add is shorter than be32_add_cpu but I think it's not clear
> > whether second parameter is in native byte order or not.
>
> Then again adding foreing endian values doesn't make much sense.
>
> If you insist on your naming please make sure to convert ocfs and xfs
> to your naming.
Personally, I'd rather stick with the (IMHO) more descriptive name - btw,
the ones he picked don't require any extra conversion in Ocfs2.
--Mark
--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@oracle.com
next prev parent reply other threads:[~2007-12-31 19:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 19:06 [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Marcin Slusarz
2007-12-30 19:18 ` Christoph Hellwig
2007-12-30 21:49 ` Marcin Slusarz
2007-12-31 9:17 ` Christoph Hellwig
2007-12-31 19:41 ` Mark Fasheh [this message]
2007-12-31 19:38 ` Mark Fasheh
2007-12-31 20:05 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071231194146.GT13821@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=hch@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox