From: Johannes Berg <johannes@sipsolutions.net>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+49d4cab497c2142ee170@syzkaller.appspotmail.com
Subject: Re: [PATCH] net: mac80211: cfg: enforce sanity checks for key_index in ieee80211_del_key()
Date: Tue, 01 Dec 2020 13:56:13 +0100 [thread overview]
Message-ID: <2007533d7d6466fc5e6b588df148238046e25b4c.camel@sipsolutions.net> (raw)
In-Reply-To: <a122ca3c-6b1b-3d03-08e3-ac1906ab7389@gmail.com> (sfid-20201201_134519_457943_AF72D8E2)
On Tue, 2020-12-01 at 18:15 +0530, Anant Thazhemadam wrote:
>
> cfg80211_supported_cipher_suite(&rdev->wiphy, params->cipher) returned
> false, and thus it worked for the syzbot reproducer.
> Would it be a safer idea to enforce the conditions that I initially put (in
> ieee80211_del_key()) directly in cfg80211_validate_key_settings() itself - by
> updating max_key_index, and checking accordingly?
Yes, I think so. But similarly to cfg80211_validate_key_settings() it
should look at the device capabilities (beacon protection, etc.)
Thanks!
johannes
prev parent reply other threads:[~2020-12-01 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 9:56 [PATCH] net: mac80211: cfg: enforce sanity checks for key_index in ieee80211_del_key() Anant Thazhemadam
2020-12-01 10:00 ` Johannes Berg
2020-12-01 11:56 ` Anant Thazhemadam
2020-12-01 12:06 ` Johannes Berg
2020-12-01 12:45 ` Anant Thazhemadam
2020-12-01 12:56 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2007533d7d6466fc5e6b588df148238046e25b4c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=anant.thazhemadam@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+49d4cab497c2142ee170@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox