From: Mike Frysinger <vapier@gentoo.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: asm-x86/byteorder.h: clean up for userspace
Date: Tue, 1 Jan 2008 13:17:11 -0500 [thread overview]
Message-ID: <200801011317.13027.vapier@gentoo.org> (raw)
In-Reply-To: <20080101174708.GA25089@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
On Tuesday 01 January 2008, Christoph Hellwig wrote:
> On Mon, Dec 31, 2007 at 01:12:45PM -0500, Mike Frysinger wrote:
> > Since asm-x86/byteorder.h is exported to userspace, use __asm__ rather
> > than asm in its code.
>
> The correct fix is to not export it to userspace.
which is what people complained last time and upon further investigation, it
isnt trivial to remove. so until then, it should be made clean. especially
considering the proposed changes are perfectly fine when used inside and
outside of the kernel.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2008-01-01 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 18:12 asm-x86/byteorder.h: clean up for userspace Mike Frysinger
2008-01-01 15:22 ` Ingo Molnar
2008-01-01 17:47 ` Christoph Hellwig
2008-01-01 18:17 ` Mike Frysinger [this message]
2008-01-01 21:19 ` H. Peter Anvin
2008-01-02 1:31 ` Adrian Bunk
2008-01-02 2:22 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801011317.13027.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox