* [2.6 patch] CIFS: #if 0 mode_to_access_flags()
@ 2008-01-01 13:46 Adrian Bunk
2008-01-01 18:10 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-01-01 13:46 UTC (permalink / raw)
To: sfrench; +Cc: linux-cifs-client, linux-kernel
This patch #if 0's the unused mode_to_access_flags(), fixing the
following compile warning:
<-- snip -->
...
CC fs/cifs/cifsacl.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/fs/cifs/cifsacl.c:200: warning: ‘mode_to_access_flags’ defined but not used
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
fs/cifs/cifsacl.c | 2 ++
1 file changed, 2 insertions(+)
0cf530f754b974ee5e58b3346828bb5586440c92
diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
index c312adc..771a22f 100644
--- a/fs/cifs/cifsacl.c
+++ b/fs/cifs/cifsacl.c
@@ -189,6 +189,7 @@ static void access_flags_to_mode(__le32 ace_flags, int type, umode_t *pmode,
return;
}
+#if 0
/*
Generate access flags to reflect permissions mode is the existing mode.
This function is called for every ACE in the DACL whose SID matches
@@ -219,6 +220,7 @@ static void mode_to_access_flags(umode_t mode, umode_t bits_to_use,
#endif
return;
}
+#endif /* 0 */
#ifdef CONFIG_CIFS_DEBUG2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [2.6 patch] CIFS: #if 0 mode_to_access_flags()
2008-01-01 13:46 [2.6 patch] CIFS: #if 0 mode_to_access_flags() Adrian Bunk
@ 2008-01-01 18:10 ` Christoph Hellwig
2008-01-01 23:46 ` Steve French
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-01-01 18:10 UTC (permalink / raw)
To: Adrian Bunk; +Cc: sfrench, linux-cifs-client, linux-kernel
On Tue, Jan 01, 2008 at 03:46:44PM +0200, Adrian Bunk wrote:
> This patch #if 0's the unused mode_to_access_flags(), fixing the
> following compile warning:
Please remove it completely instead.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] CIFS: #if 0 mode_to_access_flags()
2008-01-01 18:10 ` Christoph Hellwig
@ 2008-01-01 23:46 ` Steve French
0 siblings, 0 replies; 3+ messages in thread
From: Steve French @ 2008-01-01 23:46 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Adrian Bunk, sfrench, linux-cifs-client, linux-kernel
The cifsacl code which uses that function was not ready in time for
2.6.24 but is in the cifs development tree now..
On Jan 1, 2008 12:10 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Jan 01, 2008 at 03:46:44PM +0200, Adrian Bunk wrote:
> > This patch #if 0's the unused mode_to_access_flags(), fixing the
> > following compile warning:
>
> Please remove it completely instead.
>
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-01 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-01 13:46 [2.6 patch] CIFS: #if 0 mode_to_access_flags() Adrian Bunk
2008-01-01 18:10 ` Christoph Hellwig
2008-01-01 23:46 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox