* [2.6 patch] OSS msnd: fix array overflows
@ 2008-01-01 13:49 Adrian Bunk
2008-01-01 18:43 ` Oliver Pinter (Pintér Olivér)
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2008-01-01 13:49 UTC (permalink / raw)
To: linux-kernel
This patch fixes array overflows in the OSS msnd driver spotted by the
Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 27 Oct 2007
97463a59dfb9ccb915d3b615225c98cb3e310c0a
diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
index 05cf786..d0ca582 100644
--- a/sound/oss/msnd.h
+++ b/sound/oss/msnd.h
@@ -233,8 +233,8 @@ typedef struct multisound_dev {
spinlock_t lock;
int nresets;
unsigned long recsrc;
- int left_levels[16];
- int right_levels[16];
+ int left_levels[32];
+ int right_levels[32];
int mixer_mod_count;
int calibrate_signal;
int play_sample_size, play_sample_rate, play_channels;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [2.6 patch] OSS msnd: fix array overflows
2008-01-01 13:49 [2.6 patch] OSS msnd: fix array overflows Adrian Bunk
@ 2008-01-01 18:43 ` Oliver Pinter (Pintér Olivér)
2008-01-01 23:15 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Pinter (Pintér Olivér) @ 2008-01-01 18:43 UTC (permalink / raw)
To: Adrian Bunk, stable; +Cc: linux-kernel
then it is auch to 2.6.22-stable?
On 1/1/08, Adrian Bunk <bunk@kernel.org> wrote:
> This patch fixes array overflows in the OSS msnd driver spotted by the
> Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> This patch has been sent on:
> - 27 Oct 2007
>
> 97463a59dfb9ccb915d3b615225c98cb3e310c0a
> diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
> index 05cf786..d0ca582 100644
> --- a/sound/oss/msnd.h
> +++ b/sound/oss/msnd.h
> @@ -233,8 +233,8 @@ typedef struct multisound_dev {
> spinlock_t lock;
> int nresets;
> unsigned long recsrc;
> - int left_levels[16];
> - int right_levels[16];
> + int left_levels[32];
> + int right_levels[32];
> int mixer_mod_count;
> int calibrate_signal;
> int play_sample_size, play_sample_rate, play_channels;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Thanks,
Oliver
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] OSS msnd: fix array overflows
2008-01-01 18:43 ` Oliver Pinter (Pintér Olivér)
@ 2008-01-01 23:15 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2008-01-01 23:15 UTC (permalink / raw)
To: Oliver Pinter (Pintér Olivér); +Cc: stable, linux-kernel
On Tue, Jan 01, 2008 at 07:43:23PM +0100, Oliver Pinter (Pintér Olivér) wrote:
> then it is auch to 2.6.22-stable?
That's a very old bug in a driver for ancient hardware, so there's no
need to hurry.
> On 1/1/08, Adrian Bunk <bunk@kernel.org> wrote:
> > This patch fixes array overflows in the OSS msnd driver spotted by the
> > Coverity checker.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > ---
> >
> > This patch has been sent on:
> > - 27 Oct 2007
> >
> > 97463a59dfb9ccb915d3b615225c98cb3e310c0a
> > diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
> > index 05cf786..d0ca582 100644
> > --- a/sound/oss/msnd.h
> > +++ b/sound/oss/msnd.h
> > @@ -233,8 +233,8 @@ typedef struct multisound_dev {
> > spinlock_t lock;
> > int nresets;
> > unsigned long recsrc;
> > - int left_levels[16];
> > - int right_levels[16];
> > + int left_levels[32];
> > + int right_levels[32];
> > int mixer_mod_count;
> > int calibrate_signal;
> > int play_sample_size, play_sample_rate, play_channels;
>
> Thanks,
> Oliver
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] OSS msnd: fix array overflows
@ 2007-10-27 14:22 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2007-10-27 14:22 UTC (permalink / raw)
To: linux-kernel
This patch fixes array overflows in the OSS msnd driver spotted by the
Coverity checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
97463a59dfb9ccb915d3b615225c98cb3e310c0a
diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
index 05cf786..d0ca582 100644
--- a/sound/oss/msnd.h
+++ b/sound/oss/msnd.h
@@ -233,8 +233,8 @@ typedef struct multisound_dev {
spinlock_t lock;
int nresets;
unsigned long recsrc;
- int left_levels[16];
- int right_levels[16];
+ int left_levels[32];
+ int right_levels[32];
int mixer_mod_count;
int calibrate_signal;
int play_sample_size, play_sample_rate, play_channels;
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-01-01 23:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-01 13:49 [2.6 patch] OSS msnd: fix array overflows Adrian Bunk
2008-01-01 18:43 ` Oliver Pinter (Pintér Olivér)
2008-01-01 23:15 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2007-10-27 14:22 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox