From: WANG Cong <xiyou.wangcong@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: WANG Cong <xiyou.wangcong@gmail.com>,
Tim Shimmin <xfs-masters@oss.sgi.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
viro@zeniv.linux.org.uk
Subject: (Try #2) [Patch 7/8] FS: Drop 'TOPDIR' from Makefiles and remove some dead code
Date: Tue, 1 Jan 2008 22:28:52 +0800 [thread overview]
Message-ID: <20080101142852.GG2499@hacking> (raw)
In-Reply-To: <20080101103026.GG28913@uranus.ravnborg.org>
>
>The whole "Maintainer rules" part of this file should be deleted.
>I cannot see how it can be used anyway.
Agreed.
I delete them all and renew the patch.
Passed compiling test.
--------->
This patch drops TOPDIR since it's obsolete and removes
some dead code from fs/smbfs/Makefile.
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Tim Shimmin <xfs-masters@oss.sgi.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
---
diff --git a/fs/smbfs/Makefile b/fs/smbfs/Makefile
index 6673ee8..4faf8c4 100644
--- a/fs/smbfs/Makefile
+++ b/fs/smbfs/Makefile
@@ -16,23 +16,3 @@ EXTRA_CFLAGS += -DSMBFS_PARANOIA
#EXTRA_CFLAGS += -DDEBUG_SMB_TIMESTAMP
#EXTRA_CFLAGS += -Werror
-#
-# Maintainer rules
-#
-
-# getopt.c not included. It is intentionally separate
-SRC = proc.c dir.c cache.c sock.c inode.c file.c ioctl.c smbiod.c request.c \
- symlink.c
-
-proto:
- -rm -f proto.h
- @echo > proto2.h "/*"
- @echo >> proto2.h " * Autogenerated with cproto on: " `date`
- @echo >> proto2.h " */"
- @echo >> proto2.h ""
- @echo >> proto2.h "struct smb_request;"
- @echo >> proto2.h "struct sock;"
- @echo >> proto2.h "struct statfs;"
- @echo >> proto2.h ""
- cproto -E "gcc -E" -e -v -I $(TOPDIR)/include -DMAKING_PROTO -D__KERNEL__ $(SRC) >> proto2.h
- mv proto2.h proto.h
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
index 49e3e7e..d1d3d49 100644
--- a/fs/xfs/Makefile
+++ b/fs/xfs/Makefile
@@ -1 +1 @@
-include $(TOPDIR)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
+include $(objtree)/fs/xfs/Makefile-linux-$(VERSION).$(PATCHLEVEL)
next prev parent reply other threads:[~2008-01-01 14:28 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 7:13 [Patch 0/8] Remove 'TOPDIR' from Makefiles WANG Cong
2008-01-01 7:18 ` [Patch 1/8] UML: " WANG Cong
2008-01-01 10:33 ` Sam Ravnborg
2008-01-01 10:49 ` Sam Ravnborg
2008-01-01 13:01 ` (Try #2) " WANG Cong
2008-01-02 15:02 ` Jeff Dike
2008-01-02 17:27 ` Sam Ravnborg
2008-01-01 7:22 ` [Patch 2/8] MIPS: " WANG Cong
2008-01-01 10:15 ` Sam Ravnborg
2008-01-01 13:11 ` (Try #2) " WANG Cong
2008-01-01 13:44 ` Andreas Schwab
2008-01-01 17:57 ` Sam Ravnborg
2008-01-02 6:21 ` (Try #3) " WANG Cong
2008-01-02 19:24 ` Sam Ravnborg
2008-01-11 14:17 ` Ralf Baechle
2008-01-11 17:02 ` Sam Ravnborg
2008-01-14 6:26 ` WANG Cong
2008-01-01 7:25 ` [Patch 3/8] S390: " WANG Cong
2008-01-01 10:17 ` Sam Ravnborg
2008-01-01 13:27 ` (Try #2) [Patch 3/8] S390: Tiny fixes for Makefile WANG Cong
2008-01-01 17:42 ` Sam Ravnborg
2008-01-02 6:42 ` (Try #3) [Patch 3/8] S390: Remove 'TOPDIR' from Makefile WANG Cong
2008-01-02 9:31 ` Martin Schwidefsky
2008-01-02 9:49 ` Sam Ravnborg
2008-01-01 7:29 ` [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles WANG Cong
2008-01-01 10:20 ` Sam Ravnborg
2008-01-01 13:34 ` (Try #2) " WANG Cong
2008-01-02 6:27 ` (Try #3) " WANG Cong
2008-01-02 19:25 ` Sam Ravnborg
2008-01-03 17:03 ` Jesper Nilsson
2008-01-03 19:59 ` Sam Ravnborg
2008-01-01 7:33 ` [Patch 5/8] INFINIBAND: " WANG Cong
2008-01-01 10:26 ` Sam Ravnborg
2008-01-01 13:41 ` (Try #2) " WANG Cong
2008-01-02 19:26 ` Sam Ravnborg
2008-01-01 7:36 ` [Patch 6/8] FRV: " WANG Cong
2008-01-01 10:27 ` Sam Ravnborg
2008-01-01 14:00 ` (Try #2) [Patch 6/8] FRV: Drop " WANG Cong
2008-01-02 19:26 ` Sam Ravnborg
2008-01-01 7:41 ` [Patch 7/8] FS: Remove " WANG Cong
2008-01-01 10:30 ` Sam Ravnborg
2008-01-01 14:28 ` WANG Cong [this message]
2008-01-02 19:27 ` (Try #2) [Patch 7/8] FS: Drop 'TOPDIR' from Makefiles and remove some dead code Sam Ravnborg
2008-01-01 17:27 ` [xfs-masters] [Patch 7/8] FS: Remove 'TOPDIR' from Makefiles Eric Sandeen
2008-01-01 17:37 ` Sam Ravnborg
2008-01-02 5:55 ` (Try #3) [Patch 7/8] FS: Remove dead code WANG Cong
2008-01-01 7:43 ` [Patch 8/8] Remove 'TOPDIR' from the Top Makefile WANG Cong
2008-01-01 10:09 ` [Patch 0/8] Remove 'TOPDIR' from Makefiles Sam Ravnborg
2008-01-02 9:51 ` Sam Ravnborg
2008-01-03 4:37 ` WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101142852.GG2499@hacking \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).