From: Adrian Bunk <bunk@kernel.org>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2
Date: Wed, 2 Jan 2008 01:18:33 +0200 [thread overview]
Message-ID: <20080101231832.GI27566@does.not.exist> (raw)
In-Reply-To: <86802c440712301703w1929ae9fue5bf937bf7f4e005@mail.gmail.com>
On Sun, Dec 30, 2007 at 05:03:50PM -0800, Yinghai Lu wrote:
> On Dec 30, 2007 4:28 PM, Adrian Bunk <bunk@kernel.org> wrote:
> >
> > On Sun, Dec 30, 2007 at 04:01:39PM -0800, Yinghai Lu wrote:
>...
> > > the old one is in x86-mm tree
> > >
> > > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=ffcbdc220a1520d006a837f33589c7c19ffbeb76
> > >...
> >
> > Sorry for the dumb question, but what in
> >
> > + if (!smp_processor_id() && !skip_ioapic_setup && nr_ioapics)
> > + enable_IO_APIC();
> >
> > guarantees that this call doesn't happen when you hotplug CPU 0 ?
> >
>
> if CPU 0 (BSP) can be hotplug, it will be restarted via smp_callin.
> and the delta function call patch will use setup_local_APIC(NULL),
> then it will be safe.
We are talking about the version without the pointer games.
> YH
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-01-01 23:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 3:52 [PATCH] x86_64: clear IO_APIC before enabing apic error vector. v2 Yinghai Lu
2007-12-30 14:51 ` Ingo Molnar
2007-12-30 20:48 ` Yinghai Lu
2007-12-30 22:06 ` Adrian Bunk
2007-12-30 22:42 ` Yinghai Lu
2007-12-30 23:23 ` Adrian Bunk
2007-12-31 0:01 ` Yinghai Lu
2007-12-31 0:28 ` Adrian Bunk
2007-12-31 0:56 ` Yinghai Lu
2008-01-01 23:17 ` Adrian Bunk
2007-12-31 1:03 ` Yinghai Lu
2008-01-01 23:18 ` Adrian Bunk [this message]
2007-12-30 21:30 ` [PATCH] x86_64: fix section warning about enable_IO_APIC and setup_local_APIC Yinghai Lu
2007-12-30 21:29 ` Ingo Molnar
2007-12-30 21:53 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080101231832.GI27566@does.not.exist \
--to=bunk@kernel.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox