From: Mike Frysinger <vapier@gentoo.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] asm-x86/msr.h: pull in linux/types.h
Date: Wed, 2 Jan 2008 08:37:52 -0500 [thread overview]
Message-ID: <200801020837.53860.vapier@gentoo.org> (raw)
In-Reply-To: <20080102114849.GA25887@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Wednesday 02 January 2008, Ingo Molnar wrote:
> * Mike Frysinger <vapier@gentoo.org> wrote:
> > Forgot to mention this before, but since the msr.h header uses types
> > like __u32, it should pull in linux/types.h.
>
> does not build with the attached config.
sorry, forgot about __ASSEMBLY__ protection.
---
Since the msr.h header uses types like __u32, it should pull in linux/types.h.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/include/asm-x86/msr.h b/include/asm-x86/msr.h
index 664a2fa..80b0270 100644
--- a/include/asm-x86/msr.h
+++ b/include/asm-x86/msr.h
@@ -3,6 +3,10 @@
#include <asm/msr-index.h>
+#ifndef __ASSEMBLY__
+# include <linux/types.h>
+#endif
+
#ifdef __i386__
#ifdef __KERNEL__
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2008-01-02 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 1:08 [patch] asm-x86/msr.h: pull in linux/types.h Mike Frysinger
2008-01-02 11:48 ` Ingo Molnar
2008-01-02 13:37 ` Mike Frysinger [this message]
2008-01-02 16:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801020837.53860.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox