public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: David Miller <davem@davemloft.net>
Cc: hch@infradead.org, bunk@kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch] linux/ufs_fs.h: do not export to userspace anymore
Date: Wed, 2 Jan 2008 08:40:59 -0500	[thread overview]
Message-ID: <200801020841.00332.vapier@gentoo.org> (raw)
In-Reply-To: <20080102.000444.18510965.davem@davemloft.net>

On Wednesday 02 January 2008, David Miller wrote:
> From: Christoph Hellwig <hch@infradead.org>
> > The only non-kernel user of this known to me is silo, which should just
> > have it's own header documenting the solaris sparc ufs variant it needs
> > to understand, possibly by using a copy of the kernel version at any
> > given point of time.
>
> And this is what the current SILO sources do.

then if silo has gotten its stuff together ...
---
Do not export linux/ufs_fs.h to userspace anymore as the only userspace
consumer has been fixed to not need it anymore.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index f30fa92..fd2570f 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -336,7 +336,6 @@ unifdef-y += tty.h
 unifdef-y += types.h
 unifdef-y += udf_fs_i.h
 unifdef-y += udp.h
-unifdef-y += ufs_fs.h
 unifdef-y += uinput.h
 unifdef-y += uio.h
 unifdef-y += unistd.h
diff --git a/include/linux/ufs_fs.h b/include/linux/ufs_fs.h
index 10b854d..46e4a8d 100644
--- a/include/linux/ufs_fs.h
+++ b/include/linux/ufs_fs.h
@@ -35,16 +35,10 @@
 #include <linux/stat.h>
 #include <linux/fs.h>
 
-#ifndef __KERNEL__
-typedef __u64 __fs64;
-typedef __u32 __fs32;
-typedef __u16 __fs16;
-#else
 #include <asm/div64.h>
 typedef __u64 __bitwise __fs64;
 typedef __u32 __bitwise __fs32;
 typedef __u16 __bitwise __fs16;
-#endif
 
 #define UFS_BBLOCK 0
 #define UFS_BBSIZE 8192

      parent reply	other threads:[~2008-01-02 13:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02  1:51 [patch] linux/ufs_fs.h: use __u64 for userspace Mike Frysinger
2008-01-02  2:02 ` Adrian Bunk
2008-01-02  7:50   ` Christoph Hellwig
2008-01-02  8:04     ` David Miller
2008-01-02  8:10       ` Christoph Hellwig
2008-01-02 13:40       ` Mike Frysinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801020841.00332.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@kernel.org \
    --cc=davem@davemloft.net \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox