Re: WARNING: do not add new typedefs - is that for real?

Christoph Hellwig
2008-01-02T10:09:08Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 502 bytes --]

On Tue, Jan 01, 2008 at 06:15:46PM +0200, Boaz Harrosh wrote:
> I have this code:
>
> <c_code>
> /*
> * osd-r10 4.12.5 Data-In and Data-Out buffer offsets
> * byte offset = mantissa * (2^(exponent+8))
> */
> typedef __be32 osd_cdb_offset;

Given that you can't do normal arithmetic on this type it should't
really be a __be32 but it's own __bitwise type with proper accessors.

But yes, this is one of the rare cases where a typedef makes sense,
but Í'd call it osd_off_t or something like that.