From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Quentin Barnes <qbarnes@gmail.com>,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH] [CFT] Code clarification patch to Kprobes arch code
Date: Wed, 2 Jan 2008 20:29:08 +0530 [thread overview]
Message-ID: <20080102145908.GA6527@in.ibm.com> (raw)
In-Reply-To: <20080102123355.GB11208@elte.hu>
On Wed, Jan 02, 2008 at 01:33:55PM +0100, Ingo Molnar wrote:
>
> * Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
>
> > > Signed-off-by: Quentin Barnes <qbarnes@gmail.com>
> > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >
> > Tested on x86.
> >
> > Acked-by: Ananth N Mavinakayahanalli <ananth@in.ibm.com>
>
> thanks Ananth, i've updated the patch.
Hi Ingo,
> btw., do you have some script that i could use to test kprobes
> functionality? Right now the only time i notice kprobes regressions is
> when randconfig picks up CONFIG_NET_TCPPROBE=y which activates kprobes.
>
> It would be so much nicer if kprobes had some runs-during-bootup kind of
> quick self-test, with all the important functionality unit-tested. Like
> lib/locking-selftest.c, or CONFIG_RCU_TORTURE_TEST=y.
The simplest way to do a basic sanity check is build the kprobes samples/
and try them out. We have one sample each to test kprobes, kretprobes
and jprobes. This should serve the purpose.
I had posted patches for the same sometime back
(http://marc.info/?l=linux-kernel&m=119297044801420&w=2), but they needed
some rework to fix a build break on sparc64
(http://marc.info/?l=linux-kernel&m=119735423212298&w=2).
I will rebase the patchset against the latest mm and repost soon...
Ananth
prev parent reply other threads:[~2008-01-02 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-31 17:29 [PATCH] [CFT] Code clarification patch to Kprobes arch code Quentin Barnes
2008-01-01 15:19 ` Ingo Molnar
2008-01-02 4:43 ` Ananth N Mavinakayanahalli
2008-01-02 12:33 ` Ingo Molnar
2008-01-02 14:59 ` Ananth N Mavinakayanahalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102145908.GA6527@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=qbarnes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox