public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: linux-usb-devel@lists.sourceforge.net, gregkh@suse.de,
	linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] : Allow embedded developers USB options normally reserved for OTG
Date: Wed, 2 Jan 2008 19:43:38 -0800	[thread overview]
Message-ID: <200801021943.38716.david-b@pacbell.net> (raw)
In-Reply-To: <200801022203.04991.rgetz@blackfin.uclinux.org>

On Wednesday 02 January 2008, Robin Getz wrote:
> On Wed 2 Jan 2008 13:47, David Brownell pondered:
> > On Wednesday 02 January 2008, Robin Getz wrote:
> > > From: Robin Getz <rgetz@blackfin.uclinux.org>
> > > 
> > > Allow embedded developers to turn support for USB Hubs off even if
> > > they have a full root hub. This saves the overhead (RAM and Flash size).
> > 
> > ISTR that it won't save very much code though ... the Linux USB
> > stack structures all its enumeration logic around hubs.
> 
> Today, there is an USB (Host), USB_GADGET and USB_OTG (which depends on USB && 
> USB_GADGET).
> 
> This just enables cutting more code out, with out having to have USB_GADGET & 
> USB_OTG enabled. When I checked - that is where most of the savings came 
> from.

Right.  I'm not objecting to this at all.  Just pointing
out that usbcore will still end up including quite a lot
of hub functionality, because there's still going to be
a root hub in the system and a khubd managing it.

This patch might be improved slightly -- in ways that, as I
understand things, could save some RAM on Blackfin! -- by
having the BLACKLIST_HUB option get rid of the transaction
translator support (changing C code not just Kconfig).
It's pretty minimal, but won't be used...

Also, as you point out, it's no longer OTG specific, so
renaming the option would improve clarity.   Maybe to
something along the lines of USB_HOST_NO_EXTERNAL_HUBS.
No big deal, at least now.

- Dave


  reply	other threads:[~2008-01-03  3:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 14:48 [PATCH] : Allow embedded developers USB options normally reserved for OTG Robin Getz
2008-01-02 18:47 ` [linux-usb-devel] " David Brownell
2008-01-02 18:57   ` Felipe Balbi
2008-01-02 19:14     ` David Brownell
2008-01-02 18:58   ` Mike Frysinger
2008-01-02 19:16     ` David Brownell
2008-01-02 19:46     ` Alan Stern
2008-01-02 20:25       ` David Brownell
2008-01-02 20:58         ` Alan Stern
2008-01-03  3:50           ` David Brownell
2008-01-03  3:52           ` Bryan Wu
2008-01-03 17:01           ` Richard D
2008-01-03  3:03   ` Robin Getz
2008-01-03  3:43     ` David Brownell [this message]
2008-01-03  4:40       ` Bryan Wu
2008-01-03  7:36         ` David Brownell
2008-01-03  8:05           ` Bryan Wu
2008-01-03 17:04             ` Richard D
2008-01-04  1:20               ` Robin Getz
2008-01-03  7:58       ` Robin Getz
2008-01-03  3:47   ` Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801021943.38716.david-b@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=rgetz@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox