From: Christoph Hellwig <hch@infradead.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@shadowen.org>,
Randy Dunlap <rdunlap@xenotime.net>,
Joel Schopp <jschopp@austin.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: WARNING: do not add new typedefs - is that for real?
Date: Wed, 2 Jan 2008 20:37:35 +0000 [thread overview]
Message-ID: <20080102203735.GB15099@infradead.org> (raw)
In-Reply-To: <477B8113.6080602@panasas.com>
On Wed, Jan 02, 2008 at 02:18:27PM +0200, Boaz Harrosh wrote:
> > But yes, this is one of the rare cases where a typedef makes sense,
> > but ???'d call it osd_off_t or something like that.
> >
>
> You mean osd_cdb_offset_t. I thought of dropping that _t, I hate it,
> just a personal preference.
No, I mean osd_off_t :) off vs offset is purely cosmetic, but in Linux
we have a strong preference for short typenames. Just look how ugly
the prototype and struct defintion in your original posting look :)
Also I thing the _cdb is superflous because there is no other offset
type in the OSD spec.
prev parent reply other threads:[~2008-01-02 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-01 16:15 WARNING: do not add new typedefs - is that for real? Boaz Harrosh
2008-01-02 9:58 ` Andy Whitcroft
2008-01-02 10:08 ` Christoph Hellwig
2008-01-02 12:18 ` Boaz Harrosh
2008-01-02 20:37 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080102203735.GB15099@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=bharrosh@panasas.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox