From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: qbarnes <qbarnes@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Use is_kprobe_fault to better match usage
Date: Thu, 3 Jan 2008 10:38:37 +0100 [thread overview]
Message-ID: <20080103093837.GA18355@elte.hu> (raw)
In-Reply-To: <1199322323.6323.76.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> Currently the notify_page_fault helper is used to test it the page
> fault was caused by a kprobe causing an early return from
> do_page_fault.
>
> Change the name of the helper to is_kprobe_fault to match the usage
> and remove the preempt_disable/enable pair around kprobe_running()
> with an explicit test for preemption. The idea for this comes from a
> patch by Quentin Barnes to kprobes.c
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
hm, this doesnt apply:
Hunk #3 FAILED at 426.
Hunk #4 succeeded at 413 (offset -22 lines).
1 out of 4 hunks FAILED -- rejects in file arch/x86/mm/fault_32.c
patching file arch/x86/mm/fault_64.c
Hunk #3 FAILED at 476.
Hunk #4 succeeded at 475 (offset -10 lines).
1 out of 4 hunks FAILED -- rejects in file arch/x86/mm/fault_64.c
could you double-check x86.git#mm, perhaps we are out of sync with a
patch somewhere?
Ingo
prev parent reply other threads:[~2008-01-03 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 1:05 [PATCH] x86: Use is_kprobe_fault to better match usage Harvey Harrison
2008-01-03 2:36 ` Masami Hiramatsu
2008-01-03 3:00 ` Harvey Harrison
2008-01-03 3:20 ` Masami Hiramatsu
2008-01-03 9:38 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080103093837.GA18355@elte.hu \
--to=mingo@elte.hu \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qbarnes@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox