public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: akpm@linux-foundation.org, lkml <linux-kernel@vger.kernel.org>,
	Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
	davem@davemloft.net, mathieu.desnoyers@polymtl.ca,
	hskinnemoen@atmel.com, mhiramat@redhat.com, sam@ravnborg.org,
	randy.dunlap@oracle.com
Subject: Re: [PATCH 2/2] Kprobes: Move kprobes examples to samples/
Date: Thu, 3 Jan 2008 15:52:33 +0530	[thread overview]
Message-ID: <20080103102233.GB28934@in.ibm.com> (raw)
In-Reply-To: <20080103093303.GB16803@elte.hu>

On Thu, Jan 03, 2008 at 10:33:03AM +0100, Ingo Molnar wrote:
> 
> * Ananth N Mavinakayanahalli <ananth@in.ibm.com> wrote:
> 
> > From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> > 
> > Move kprobes examples from Documentation/kprobes.txt to under 
> > samples/. Patch originally by Randy Dunlap.
> 
> nice!
> 
> > +config SAMPLE_KPROBES
> > +	tristate "Build kprobes examples -- loadable modules only"
> > +	depends on KPROBES && m
> > +	help
> > +	  This build several kprobes example modules.
> 
> feature request: please make this work in the !modular case as well - if 
> built-in then it should just run sometime during bootup and run the 
> tests and report success/failure. This way automated testing can pick up 
> any regressions much easier.

Will try cook up something along those lines. It'll be easy to verify if
the probes inserted and removed properly, but verifying handlers run
correctly will need some work.

We have a sort of regression test bucket that uses expect to parse the
dmesg to verify handlers did run correctly; that isn't a totally
in-kernel solution anyway. I have a couple of ideas in mind to make it
easier.

Ananth

  reply	other threads:[~2008-01-03 10:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-03  6:24 [PATCH 1/2] Kprobes: Indicate kretprobe support in Kconfig Ananth N Mavinakayanahalli
2008-01-03  6:28 ` [PATCH 2/2] Kprobes: Move kprobes examples to samples/ Ananth N Mavinakayanahalli
2008-01-03  9:33   ` Ingo Molnar
2008-01-03 10:22     ` Ananth N Mavinakayanahalli [this message]
2008-01-03 11:04       ` Ingo Molnar
2008-01-03 15:18         ` Mathieu Desnoyers
2008-01-03 15:44           ` Ananth N Mavinakayanahalli
  -- strict thread matches above, loose matches on Subject: below --
2008-02-05  5:10 [PATCH 1/2] Kprobes: Indicate kretprobe support in Kconfig Ananth N Mavinakayanahalli
2008-02-05  5:12 ` [PATCH 2/2] Kprobes: Move kprobes examples to samples/ Ananth N Mavinakayanahalli
2008-02-05  5:36   ` Abhishek Sagar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103102233.GB28934@in.ibm.com \
    --to=ananth@in.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=davem@davemloft.net \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=randy.dunlap@oracle.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox