From: "Jörn Engel" <joern@logfs.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [x86] kernel/audit.c cleanup according to checkpatch.pl
Date: Thu, 3 Jan 2008 12:29:57 +0100 [thread overview]
Message-ID: <20080103112957.GA14693@lazybastard.org> (raw)
In-Reply-To: <20080103111925.GC8046@cvg>
On Thu, 3 January 2008 14:19:25 +0300, Cyrill Gorcunov wrote:
> @@ -232,7 +232,8 @@ void audit_log_lost(const char *message)
>
> if (print) {
> printk(KERN_WARNING
> - "audit: audit_lost=%d audit_rate_limit=%d audit_backlog_limit=%d\n",
> + "audit: audit_lost=%d audit_rate_limit=%d "
> + "audit_backlog_limit=%d\n",
> atomic_read(&audit_lost),
> audit_rate_limit,
> audit_backlog_limit);
This hunk is a bit questionable. It can easily deceive a reader to
assume two seperate lines printed out and sometimes defeats grepping
for printk output to find the code generating the message.
Rest looks good to me.
Jörn
--
He that composes himself is wiser than he that composes a book.
-- B. Franklin
next prev parent reply other threads:[~2008-01-03 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 11:19 [x86] kernel/audit.c cleanup according to checkpatch.pl Cyrill Gorcunov
2008-01-03 11:29 ` Jörn Engel [this message]
2008-01-03 11:46 ` Cyrill Gorcunov
2008-01-03 12:10 ` Tomas Carnecky
2008-01-03 12:16 ` Cyrill Gorcunov
2008-01-03 14:05 ` Ingo Molnar
2008-01-03 14:29 ` David Woodhouse
2008-01-03 14:37 ` Ingo Molnar
2008-01-03 14:37 ` David Woodhouse
2008-01-03 14:50 ` Cyrill Gorcunov
2008-01-03 14:57 ` David Woodhouse
2008-01-03 16:31 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080103112957.GA14693@lazybastard.org \
--to=joern@logfs.org \
--cc=dwmw2@infradead.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox